Skip to content

Fix cwe tags to include leading zero #19429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 3 commits into from
May 1, 2025
Merged

Fix cwe tags to include leading zero #19429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf614a5
Fix cwe tags to include leading zero
owen-mc Apr 30, 2025
a9132c4
Fix incorrect CWE tags
owen-mc Apr 30, 2025
0863c87
Add change notes
owen-mc May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-014/MemsetMayBeDeleted.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @security-severity 7.8
* @precision high
* @tags security
* external/cwe/cwe-14
* external/cwe/cwe-014
*/

import cpp
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-020/CountUntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id cpp/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import cpp
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-020/IRCountUntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id cpp/count-untrusted-data-external-api-ir
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import cpp
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-020/IRUntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import cpp
Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/src/Security/CWE/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import cpp
Expand Down
9 changes: 9 additions & 0 deletions cpp/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
category: queryMetadata
---
* The tag `external/cwe/cwe-14` has been removed from `cpp/memset-may-be-deleted` and the tag `external/cwe/cwe-014` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cpp/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cpp/count-untrusted-data-external-api-ir` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cpp/untrusted-data-to-external-api-ir` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cpp/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cpp/late-check-of-function-argument` and the tag `external/cwe/cwe-020` has been added.
2 changes: 1 addition & 1 deletion cpp/ql/src/experimental/Security/CWE/CWE-020/LateCheckOfFunctionArgument.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @tags correctness
* security
* experimental
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import cpp
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Configuration/PasswordInConfigurationFile.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @precision medium
* @id cs/password-in-configuration
* @tags security
* external/cwe/cwe-13
* external/cwe/cwe-013
* external/cwe/cwe-256
* external/cwe/cwe-313
*/
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-011/ASPNetDebug.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* @tags security
* maintainability
* frameworks/asp.net
* external/cwe/cwe-11
* external/cwe/cwe-011
* external/cwe/cwe-532
*/

Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-016/ASPNetMaxRequestLength.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @id cs/web/large-max-request-length
* @tags security
* frameworks/asp.net
* external/cwe/cwe-16
* external/cwe/cwe-016
*/

import csharp
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequest.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @id cs/web/request-validation-disabled
* @tags security
* frameworks/asp.net
* external/cwe/cwe-16
* external/cwe/cwe-016
*/

import csharp
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-020/ExternalAPIsUsedWithUntrustedData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id cs/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import csharp
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-020/RuntimeChecksBypass.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @security-severity 7.8
* @precision medium
* @tags security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import semmle.code.csharp.serialization.Serialization
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import csharp
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Security Features/CWE-248/MissingASPNETGlobalErrorHandler.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @precision high
* @id cs/web/missing-global-error-handler
* @tags security
* external/cwe/cwe-12
* external/cwe/cwe-012
* external/cwe/cwe-248
*/

Expand Down
12 changes: 12 additions & 0 deletions csharp/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
category: queryMetadata
---

* The tag `external/cwe/cwe-13` has been removed from `cs/password-in-configuration` and the tag `external/cwe/cwe-013` has been added.
* The tag `external/cwe/cwe-11` has been removed from `cs/web/debug-binary` and the tag `external/cwe/cwe-011` has been added.
* The tag `external/cwe/cwe-16` has been removed from `cs/web/large-max-request-length` and the tag `external/cwe/cwe-016` has been added.
* The tag `external/cwe/cwe-16` has been removed from `cs/web/request-validation-disabled` and the tag `external/cwe/cwe-016` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cs/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cs/serialization-check-bypass` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `cs/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-12` has been removed from `cs/web/missing-global-error-handler` and the tag `external/cwe/cwe-012` has been added.
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id go/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/IncompleteHostnameRegexp.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @id go/incomplete-hostname-regexp
* @tags correctness
* security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/MissingRegexpAnchor.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @id go/regex/missing-regexp-anchor
* @tags correctness
* security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/SuspiciousCharacterInRegexp.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @id go/suspicious-character-in-regex
* @tags correctness
* security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import go
Expand Down
14 changes: 14 additions & 0 deletions go/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
category: queryMetadata
---

* The tag `external/cwe/cwe-20` has been removed from `go/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `go/incomplete-hostname-regexp` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `go/regex/missing-regexp-anchor` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `go/suspicious-character-in-regex` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `go/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `go/untrusted-data-to-unknown-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-90` has been removed from `go/ldap-injection` and the tag `external/cwe/cwe-090` has been added.
* The tag `external/cwe/cwe-74` has been removed from `go/dsn-injection` and the tag `external/cwe/cwe-074` has been added.
* The tag `external/cwe/cwe-74` has been removed from `go/dsn-injection-local` and the tag `external/cwe/cwe-074` has been added.
* The tag `external/cwe/cwe-79` has been removed from `go/html-template-escaping-passthrough` and the tag `external/cwe/cwe-079` has been added.
2 changes: 1 addition & 1 deletion go/ql/src/experimental/CWE-090/LDAPInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @id go/ldap-injection
* @tags security
* experimental
* external/cwe/cwe-90
* external/cwe/cwe-090
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/experimental/CWE-74/DsnInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @id go/dsn-injection
* @tags security
* experimental
* external/cwe/cwe-74
* external/cwe/cwe-074
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/experimental/CWE-74/DsnInjectionLocal.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @id go/dsn-injection-local
* @tags security
* experimental
* external/cwe/cwe-74
* external/cwe/cwe-074
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion go/ql/src/experimental/CWE-79/HTMLTemplateEscapingPassthrough.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @id go/html-template-escaping-passthrough
* @tags security
* experimental
* external/cwe/cwe-79
* external/cwe/cwe-079
*/

import go
Expand Down
2 changes: 1 addition & 1 deletion java/ql/src/Security/CWE/CWE-020/ExternalAPIsUsedWithUntrustedData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id java/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import java
Expand Down
2 changes: 1 addition & 1 deletion java/ql/src/Security/CWE/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import java
Expand Down
2 changes: 1 addition & 1 deletion java/ql/src/Security/CWE/CWE-113/NettyResponseSplitting.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* @precision high
* @id java/netty-http-request-or-response-splitting
* @tags security
* external/cwe/cwe-93
* external/cwe/cwe-093
* external/cwe/cwe-113
*/

Expand Down
7 changes: 7 additions & 0 deletions java/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
category: queryMetadata
---

* The tag `external/cwe/cwe-20` has been removed from `java/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `java/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-93` has been removed from `java/netty-http-request-or-response-splitting` and the tag `external/cwe/cwe-093` has been added.
2 changes: 1 addition & 1 deletion javascript/ql/src/Electron/DisablingWebSecurity.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @precision very-high
* @tags security
* frameworks/electron
* external/cwe/cwe-79
* external/cwe/cwe-079
* @id js/disabling-electron-websecurity
*/

Expand Down
2 changes: 1 addition & 1 deletion javascript/ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id js/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import javascript
Expand Down
2 changes: 1 addition & 1 deletion javascript/ql/src/Security/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import javascript
Expand Down
8 changes: 8 additions & 0 deletions javascript/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
category: queryMetadata
---

* The tag `external/cwe/cwe-79` has been removed from `js/disabling-electron-websecurity` and the tag `external/cwe/cwe-079` has been added.
* The tag `external/cwe/cwe-20` has been removed from `js/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `js/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `js/untrusted-data-to-external-api-more-sources` and the tag `external/cwe/cwe-020` has been added.
2 changes: 1 addition & 1 deletion ...ript/ql/src/experimental/heuristics/ql/src/Security/CWE-020/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @problem.severity error
* @security-severity 7.8
* @tags experimental
* security external/cwe/cwe-20
* security external/cwe/cwe-020
*/

import javascript
Expand Down
4 changes: 2 additions & 2 deletions python/ql/src/Expressions/UseofInput.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
* @kind problem
* @tags security
* correctness
* security/cwe/cwe-94
* security/cwe/cwe-95
* external/cwe/cwe-094
* external/cwe/cwe-095
* @problem.severity error
* @security-severity 9.8
* @sub-severity high
Expand Down
2 changes: 1 addition & 1 deletion python/ql/src/Security/CWE-020-ExternalAPIs/ExternalAPIsUsedWithUntrustedData.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* to it.
* @id py/count-untrusted-data-external-api
* @kind table
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import python
Expand Down
2 changes: 1 addition & 1 deletion python/ql/src/Security/CWE-020-ExternalAPIs/UntrustedDataToExternalAPI.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* @precision low
* @problem.severity error
* @security-severity 7.8
* @tags security external/cwe/cwe-20
* @tags security external/cwe/cwe-020
*/

import python
Expand Down
2 changes: 1 addition & 1 deletion python/ql/src/Security/CWE-020/CookieInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* @security-severity 5.0
* @id py/cookie-injection
* @tags security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import python
Expand Down
2 changes: 1 addition & 1 deletion python/ql/src/Security/CWE-020/IncompleteUrlSubstringSanitization.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @id py/incomplete-url-substring-sanitization
* @tags correctness
* security
* external/cwe/cwe-20
* external/cwe/cwe-020
*/

import python
Expand Down
10 changes: 10 additions & 0 deletions python/ql/src/change-notes/2025-05-01-cwe-tag-changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
category: queryMetadata
---

* The tags `security/cwe/cwe-94` and `security/cwe/cwe-95` have been removed from `py/use-of-input` and the tags `external/cwe/cwe-094` and `external/cwe/cwe-095` have been added.
* The tag `external/cwe/cwe-20` has been removed from `py/count-untrusted-data-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `py/untrusted-data-to-external-api` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `py/cookie-injection` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-20` has been removed from `py/incomplete-url-substring-sanitization` and the tag `external/cwe/cwe-020` has been added.
* The tag `external/cwe/cwe-94` has been removed from `py/js2py-rce` and the tag `external/cwe/cwe-094` has been added.
Loading
Loading