-
Notifications
You must be signed in to change notification settings - Fork 1.9k
JS: Incremental API graph #20733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asgerf
wants to merge
42
commits into
github:main
Choose a base branch
from
asgerf:js/incremental-api-graphs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JS: Incremental API graph #20733
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
12c0ad0
JS: Stop dependeding on getPath() for toString()
asgerf 7fc8753
JS: Make MkSyntheticCallbackArg() independent of trackUseNode
asgerf 8f41385
JS: Make other node types not depend on tracking predicates
asgerf fd65eeb
JS: Make use() and rhs() uncached and private
asgerf 465f4b9
JS: Wrap in a module
asgerf 10db30a
JS: Parameterise the module (still only one instantiation)
asgerf b69f853
JS: Moving 'cache' annotations outside the parameterised module
asgerf c8108d1
JS: Localize charpred of API::EntryPoint
asgerf 3110e5a
JS: Localize MkModuleExport
asgerf a2a9518
JS: Localize MkModuleImport
asgerf 385bb32
JS: Localize MkClassInstance
asgerf 3ed0f36
JS: Use forceLocal to localize MkTypeUse
asgerf 6c00a7f
JS: Remove unused predicate
asgerf 295bc69
JS: Make API nodes and labels local
asgerf 123bc64
JS: Improve join order at MkUse call
asgerf 271567c
JS: Add missing def-node roots
asgerf daf04f1
JS: Call forceLocal on the output of Stage 1
asgerf b12d927
JS: Also expose "any state" version of tracking predicates
asgerf 1001e86
JS: Restrict Stage1 to the base database
asgerf 9c37e07
JS: Add overlay-specific Stage2
asgerf c9d3f06
JS:Add more member labels
asgerf 4bd0f34
JS: Add debug tools for detecting lost nodes/edges
asgerf 825c083
JS: Change signature of 'edges' to support quick eval
asgerf a6dfb83
JS: Add back CallReceiverStep() restriction
asgerf cf0e765
JS: Remove global dependency that wasnt needed anyway
asgerf c687dc9
JS: Add overlay[global] to abstract classes with fields
asgerf ed3a8bd
JS: Include import paths from custom ModuleImportNode::Range subclasses
asgerf 651608a
JS: Bugfix in Stage1Local::trackDefNode
asgerf 7974416
JS: Simplify toString()
asgerf 962c128
JS: Update test output to reflect Node.toString() change
asgerf 8731eee
JS: Work around an issue with overlay-invariance
asgerf 27e8bcb
JS: Add back promisify-all support
asgerf 97d369c
JS: Make API::Node overlay[local?]
asgerf 869efb8
JS: Sync ApiGraphModels.qll
asgerf 369848a
JS: Fix some QL4QL alerts
asgerf cae27c4
JS: Add a missing needsDefNode restriction
asgerf 9721b4e
JS: Fix bad join in export logic
asgerf d0dbc91
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf 56a6fe4
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf 87049bd
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf e16cacd
JS: Rename "in scope" to "in active file"
asgerf cf0b770
JS: Workaround forceLocal not supporting 'result' column
asgerf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1,657 changes: 997 additions & 660 deletions
1,657
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
javascript/ql/test/ApiGraphs/custom-entry-point/VerifyAssertions.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| testFailures | ||
| ambiguousPreferredPredecessor | ||
| | pack2/lib.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getInstance() | | ||
| | pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") | | ||
| | pack2/main.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("MainClass").getInstance() | | ||
| | pack2/lib.js:1:1:3:1 | instance of class A ... ethod\\n} | | ||
| | pack2/lib.js:8:22:8:34 | def function() {} | | ||
| | pack2/main.js:1:1:3:1 | instance of class A ... ethod\\n} | | ||
| ambiguousSinkName | ||
| ambiguousFunctionName | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity that we lose the "descriptive" names for API graph nodes, but I guess it's kind of necessary.