-
Notifications
You must be signed in to change notification settings - Fork 3.5k
(feat): Enhancements to Spec Kit #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sync changes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
import tomllib | ||
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | ||
if pyproject_path.exists(): | ||
with open(pyproject_path, "rb") as f: | ||
data = tomllib.load(f) | ||
cli_version = data.get("project", {}).get("version", "unknown") |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomllib
is only available in Python 3.11+. While the project requires Python >=3.11 according to pyproject.toml, the import should be wrapped in a try-except block since it's already inside an exception handler and a fallback version of "unknown" is acceptable.
import tomllib | |
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | |
if pyproject_path.exists(): | |
with open(pyproject_path, "rb") as f: | |
data = tomllib.load(f) | |
cli_version = data.get("project", {}).get("version", "unknown") | |
try: | |
import tomllib | |
except ImportError: | |
# tomllib not available, fallback to "unknown" | |
pass | |
else: | |
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | |
if pyproject_path.exists(): | |
with open(pyproject_path, "rb") as f: | |
data = tomllib.load(f) | |
cli_version = data.get("project", {}).get("version", "unknown") |
Copilot uses AI. Check for mistakes.
info_table.add_row("Template Version", template_version) | ||
info_table.add_row("Released", release_date) | ||
info_table.add_row("", "") | ||
info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}") |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The version string could be simplified using platform.python_version()
which returns the same information in a cleaner way.
info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}") | |
info_table.add_row("Python", platform.python_version()) |
Copilot uses AI. Check for mistakes.
$branches = git branch -a 2>$null | ||
if ($LASTEXITCODE -eq 0) { | ||
foreach ($branch in $branches) { | ||
# Clean branch name: remove leading markers and remote prefixes |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The regex pattern could be made more readable with a comment explaining that it removes Git's current branch marker (*), whitespace, and remote prefixes (e.g., 'remotes/origin/').
# Clean branch name: remove leading markers and remote prefixes | |
# Clean branch name: remove leading markers and remote prefixes | |
# The following regex removes: | |
# - Git's current branch marker ('*') and leading whitespace (e.g., '* main') | |
# - Remote prefixes (e.g., 'remotes/origin/') |
Copilot uses AI. Check for mistakes.
in vscode insiders i have a warning saying "Chat modes have been renamed to agents. Please move this file to .github/agents/speckit.[prompt].agent.md". should you not put this inside the new designated folder and file from vscode ? |
Description
version
command. (specify --version flag not supported, returns error #486)Screenshots
Hand-offs
Version
References
Behavior notes