Skip to content

Conversation

localden
Copy link
Collaborator

@localden localden commented Oct 21, 2025

Description

Screenshots

Hand-offs

image image

Version

image

References

Behavior notes

  • There is an unexpected behavior when hand-off occurs, resetting to Agent Mode. This will be fixed by the VS Code team.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 17:28
Copilot

This comment was marked as outdated.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 17:39
Copilot

This comment was marked as outdated.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 20:17
Copilot

This comment was marked as outdated.

Copy link

@crisweber2600 crisweber2600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 21:34
Copilot

This comment was marked as outdated.

@localden localden self-assigned this Oct 21, 2025
@localden localden added enhancement templates Related to template definition and not the CLI. labels Oct 21, 2025
@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 22:06
Copilot

This comment was marked as outdated.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 22:21
Copilot

This comment was marked as outdated.

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 23:22
Copilot

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 23:32
Copilot

This comment was marked as outdated.

localden and others added 2 commits October 21, 2025 16:56
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 02:36
Copilot

This comment was marked as outdated.

localden and others added 2 commits October 21, 2025 19:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 02:38
Copilot

This comment was marked as outdated.

@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 03:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot
Copy link

Copilot AI commented Oct 22, 2025

@localden I've opened a new pull request, #1004, to work on those changes. Once the pull request is ready, I'll request review from you.

@Copilot Copilot AI review requested due to automatic review settings October 22, 2025 20:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +1282 to +1287
import tomllib
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml"
if pyproject_path.exists():
with open(pyproject_path, "rb") as f:
data = tomllib.load(f)
cli_version = data.get("project", {}).get("version", "unknown")
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tomllib is only available in Python 3.11+. While the project requires Python >=3.11 according to pyproject.toml, the import should be wrapped in a try-except block since it's already inside an exception handler and a fallback version of "unknown" is acceptable.

Suggested change
import tomllib
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml"
if pyproject_path.exists():
with open(pyproject_path, "rb") as f:
data = tomllib.load(f)
cli_version = data.get("project", {}).get("version", "unknown")
try:
import tomllib
except ImportError:
# tomllib not available, fallback to "unknown"
pass
else:
pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml"
if pyproject_path.exists():
with open(pyproject_path, "rb") as f:
data = tomllib.load(f)
cli_version = data.get("project", {}).get("version", "unknown")

Copilot uses AI. Check for mistakes.

info_table.add_row("Template Version", template_version)
info_table.add_row("Released", release_date)
info_table.add_row("", "")
info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}")
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The version string could be simplified using platform.python_version() which returns the same information in a cleaner way.

Suggested change
info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}")
info_table.add_row("Python", platform.python_version())

Copilot uses AI. Check for mistakes.

$branches = git branch -a 2>$null
if ($LASTEXITCODE -eq 0) {
foreach ($branch in $branches) {
# Clean branch name: remove leading markers and remote prefixes
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The regex pattern could be made more readable with a comment explaining that it removes Git's current branch marker (*), whitespace, and remote prefixes (e.g., 'remotes/origin/').

Suggested change
# Clean branch name: remove leading markers and remote prefixes
# Clean branch name: remove leading markers and remote prefixes
# The following regex removes:
# - Git's current branch marker ('*') and leading whitespace (e.g., '* main')
# - Remote prefixes (e.g., 'remotes/origin/')

Copilot uses AI. Check for mistakes.

@N0SAFE
Copy link

N0SAFE commented Oct 23, 2025

in vscode insiders i have a warning saying "Chat modes have been renamed to agents. Please move this file to .github/agents/speckit.[prompt].agent.md". should you not put this inside the new designated folder and file from vscode ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement templates Related to template definition and not the CLI.

Projects

None yet

4 participants