Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/ql-vscode/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [UNRELEASED]

- Add new commands "CodeQL: Warm Overlay-Base Cache for Query", "CodeQL: Warm Overlay-Base Cache for Queries in Selected Files", and "CodeQL: Warm Overlay-Base Cache for Query Suite". These commands populate the overlay-base cache of an overlay database to prepare for incremental evaluation. They are primarily intended for overlay-specific performance debugging. [#4195](https://github.com/github/vscode-codeql/pull/4195)

## 1.17.6 - 24 October 2025

- Remove support for CodeQL CLI versions older than 2.20.7. [#4159](https://github.com/github/vscode-codeql/pull/4159)
Expand Down
46 changes: 46 additions & 0 deletions extensions/ql-vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,14 @@
"command": "codeQL.runQueryContextEditor",
"title": "CodeQL: Run Query on Selected Database"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuery",
"title": "CodeQL: Warm Overlay-Base Cache for Query"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"title": "CodeQL: Warm Overlay-Base Cache for Query"
},
{
"command": "codeQL.debugQuery",
"title": "CodeQL: Debug Query"
Expand Down Expand Up @@ -571,10 +579,18 @@
"command": "codeQL.runQueries",
"title": "CodeQL: Run Queries in Selected Files"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"title": "CodeQL: Warm Overlay-Base Cache for Queries in Selected Files"
},
{
"command": "codeQL.runQuerySuite",
"title": "CodeQL: Run Selected Query Suite"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"title": "CodeQL: Warm Overlay-Base Cache for Query Suite"
},
{
"command": "codeQL.quickEval",
"title": "CodeQL: Quick Evaluation"
Expand Down Expand Up @@ -1378,11 +1394,21 @@
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive"
},
{
"command": "codeQL.runQuerySuite",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive && resourceExtname == .qls && !explorerResourceIsFolder && !listMultiSelection && config.codeQL.canary"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive && resourceExtname == .qls && !explorerResourceIsFolder && !listMultiSelection && config.codeQL.canary"
},
{
"command": "codeQL.runVariantAnalysisContextExplorer",
"group": "9_qlCommands",
Expand All @@ -1408,6 +1434,10 @@
"command": "codeQL.runQuery",
"when": "resourceLangId == ql && resourceExtname == .ql"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuery",
"when": "resourceLangId == ql && resourceExtname == .ql"
},
{
"command": "codeQLQueries.runLocalQueryFromQueriesPanel",
"when": "false"
Expand All @@ -1428,6 +1458,10 @@
"command": "codeQL.runQueryContextEditor",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"when": "false"
},
{
"command": "codeQL.debugQuery",
"when": "config.codeQL.canary && editorLangId == ql && resourceExtname == .ql && !inDebugMode"
Expand Down Expand Up @@ -1480,10 +1514,18 @@
"command": "codeQL.runQueries",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"when": "false"
},
{
"command": "codeQL.runQuerySuite",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"when": "false"
},
{
"command": "codeQL.quickEval",
"when": "editorLangId == ql"
Expand Down Expand Up @@ -1832,6 +1874,10 @@
"command": "codeQL.runQueryContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql && !inDebugMode"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql && !inDebugMode"
},
{
"command": "codeQL.runQueryOnMultipleDatabasesContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql"
Expand Down
6 changes: 6 additions & 0 deletions extensions/ql-vscode/src/common/commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,11 @@ export type QueryEditorCommands = {
// Commands used for running local queries
export type LocalQueryCommands = {
"codeQL.runQuery": (uri?: Uri) => Promise<void>;
"codeQL.runWarmOverlayBaseCacheForQuery": (uri?: Uri) => Promise<void>;
"codeQL.runQueryContextEditor": (uri?: Uri) => Promise<void>;
"codeQL.runWarmOverlayBaseCacheForQueryContextEditor": (
uri?: Uri,
) => Promise<void>;
"codeQL.runQueryOnMultipleDatabases": (uri?: Uri) => Promise<void>;
"codeQL.runQueryOnMultipleDatabasesContextEditor": (
uri?: Uri,
Expand All @@ -138,7 +142,9 @@ export type LocalQueryCommands = {
"codeQLQueries.createQuery": () => Promise<void>;
"codeQL.runLocalQueryFromFileTab": (uri: Uri) => Promise<void>;
"codeQL.runQueries": ExplorerSelectionCommandFunction<Uri>;
"codeQL.runWarmOverlayBaseCacheForQueries": ExplorerSelectionCommandFunction<Uri>;
"codeQL.runQuerySuite": ExplorerSelectionCommandFunction<Uri>;
"codeQL.runWarmOverlayBaseCacheForQuerySuite": ExplorerSelectionCommandFunction<Uri>;
"codeQL.quickEval": (uri: Uri) => Promise<void>;
"codeQL.quickEvalCount": (uri: Uri) => Promise<void>;
"codeQL.quickEvalContextEditor": (uri: Uri) => Promise<void>;
Expand Down
4 changes: 4 additions & 0 deletions extensions/ql-vscode/src/common/logging/vscode/loggers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ export const extLogger = new OutputChannelLogger("CodeQL Extension Log");
// Logger for messages from the query server.
export const queryServerLogger = new OutputChannelLogger("CodeQL Query Server");

// Logger for messages from the query server for warming overlay-base cache.
export const queryServerForWarmingOverlayBaseCacheLogger =
new OutputChannelLogger("CodeQL Query Server for warming overlay-base cache");

// Logger for messages from the language server.
export const languageServerLogger = new OutputChannelLogger(
"CodeQL Language Server",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export class DatabaseManager extends DisposableObject {
private readonly ctx: ExtensionContext,
private readonly app: App,
private readonly qs: QueryRunner,
private readonly qsForWarmingOverlayBaseCache: QueryRunner,
private readonly cli: CodeQLCliServer,
private readonly languageContext: LanguageContextStore,
public logger: Logger,
Expand Down Expand Up @@ -739,6 +740,34 @@ export class DatabaseManager extends DisposableObject {
}
}

public async withDatabaseInQsForWarmingOverlayBaseCache(
whatToDo: () => Promise<void>,
) {
try {
if (this._currentDatabaseItem) {
const dbItem = this._currentDatabaseItem;
await this.qs.deregisterDatabase(dbItem);
await this.qsForWarmingOverlayBaseCache.registerDatabase(dbItem);
}
await whatToDo();
if (this._currentDatabaseItem) {
const dbItem = this._currentDatabaseItem;
await this.qsForWarmingOverlayBaseCache.deregisterDatabase(dbItem);
await this.qs.registerDatabase(dbItem);
}
} catch (e) {
const message = getErrorMessage(e);
if (message === "Connection is disposed.") {
// This is expected if the query server is not running.
void extLogger.log(
`Could not use database for warming overlay-base cache because query server is not running.`,
);
return;
}
throw e;
}
}

private async deregisterDatabase(dbItem: DatabaseItem) {
try {
await this.qs.deregisterDatabase(dbItem);
Expand Down
42 changes: 39 additions & 3 deletions extensions/ql-vscode/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ import {
extLogger,
languageServerLogger,
queryServerLogger,
queryServerForWarmingOverlayBaseCacheLogger,
} from "./common/logging/vscode";
import { QueryHistoryManager } from "./query-history/query-history-manager";
import type { CompletedLocalQueryInfo } from "./query-results";
Expand Down Expand Up @@ -172,6 +173,7 @@ function getCommands(
app: App,
cliServer: CodeQLCliServer,
queryRunner: QueryRunner,
queryRunnerForWarmingOverlayBaseCache: QueryRunner,
languageClient: LanguageClient,
): BaseCommands {
const getCliVersion = async () => {
Expand All @@ -189,6 +191,7 @@ function getCommands(
cliServer.restartCliServer();
await Promise.all([
queryRunner.restartQueryServer(progress),
queryRunnerForWarmingOverlayBaseCache.restartQueryServer(progress),
async () => {
if (languageClient.isRunning()) {
await languageClient.restart();
Expand All @@ -201,6 +204,10 @@ function getCommands(
queryServerLogger,
"CodeQL Query Server restarted.",
);
void showAndLogErrorMessage(
queryServerForWarmingOverlayBaseCacheLogger,
"CodeQL Query Server for warming overlay-base cache restarted.",
);
},
{
title: "Restarting Query Server",
Expand Down Expand Up @@ -281,6 +288,7 @@ export interface CodeQLExtensionInterface {
readonly ctx: ExtensionContext;
readonly cliServer: CodeQLCliServer;
readonly qs: QueryRunner;
readonly qsForWarmingOverlayBaseCache: QueryRunner;
readonly distributionManager: DistributionManager;
readonly databaseManager: DatabaseManager;
readonly databaseUI: DatabaseUI;
Expand Down Expand Up @@ -795,6 +803,16 @@ async function activateWithInstalledDistribution(
qlConfigurationListener,
cliServer,
ctx,
false,
);

void extLogger.log("Initializing base cache warming query server client.");
const qsForWarmingOverlayBaseCache = await createQueryServer(
app,
qlConfigurationListener,
cliServer,
ctx,
true,
);

for (const glob of CLEAR_PACK_CACHE_ON_EDIT_GLOBS) {
Expand Down Expand Up @@ -822,6 +840,7 @@ async function activateWithInstalledDistribution(
ctx,
app,
qs,
qsForWarmingOverlayBaseCache,
cliServer,
languageContext,
extLogger,
Expand Down Expand Up @@ -998,6 +1017,7 @@ async function activateWithInstalledDistribution(
const localQueries = new LocalQueries(
app,
qs,
qsForWarmingOverlayBaseCache,
qhm,
dbm,
databaseFetcher,
Expand Down Expand Up @@ -1062,7 +1082,13 @@ async function activateWithInstalledDistribution(
void extLogger.log("Registering top-level command palette commands.");

const allCommands: AllExtensionCommands = {
...getCommands(app, cliServer, qs, languageClient),
...getCommands(
app,
cliServer,
qs,
qsForWarmingOverlayBaseCache,
languageClient,
),
...getQueryEditorCommands({
commandManager: app.commands,
queryRunner: qs,
Expand Down Expand Up @@ -1165,6 +1191,7 @@ async function activateWithInstalledDistribution(
cliServer,
localQueries,
qs,
qsForWarmingOverlayBaseCache,
distributionManager,
databaseManager: dbm,
databaseUI,
Expand Down Expand Up @@ -1278,9 +1305,12 @@ async function createQueryServer(
qlConfigurationListener: QueryServerConfigListener,
cliServer: CodeQLCliServer,
ctx: ExtensionContext,
warmOverlayBaseCache: boolean,
): Promise<QueryRunner> {
const qsOpts = {
logger: queryServerLogger,
logger: warmOverlayBaseCache
? queryServerForWarmingOverlayBaseCacheLogger
: queryServerLogger,
contextStoragePath: getContextStoragePath(ctx),
};
const progressCallback = (
Expand All @@ -1290,7 +1320,12 @@ async function createQueryServer(
) => Thenable<void>,
) =>
Window.withProgress(
{ title: "CodeQL query server", location: ProgressLocation.Window },
{
title: warmOverlayBaseCache
? "CodeQL query server for warming overlay-base cache"
: "CodeQL query server",
location: ProgressLocation.Window,
},
task,
);

Expand All @@ -1300,6 +1335,7 @@ async function createQueryServer(
cliServer,
qsOpts,
progressCallback,
warmOverlayBaseCache,
);
ctx.subscriptions.push(qs);
await qs.startQueryServer();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export function getAstCfgCommands({
progress,
token,
undefined,
false,
undefined,
res[1],
);
Expand Down
Loading