Deprecate _ as x patterns #4683

eutampieri · 2025-06-13T14:03:13Z

This aims to fix #4664.
I'm new here, so I hope to have done everything right.

giacomocavalieri · 2025-06-13T14:23:59Z

Looks good so far Eugenio! Could you add some tests for both the formatting and the warning? You can have a look at the format::test and type::tests::warnings modules for that

eutampieri · 2025-06-13T15:34:48Z

🌟 Added tests! 🌟

lpil

Hello! Could you rebase on main please? There's some conflicts. Thank you

lpil · 2025-06-17T16:17:43Z

compiler-core/src/warning.rs

+
+                type_::Warning::UnusedDiscardPattern { location, name } => Diagnostic {
+                    title: "Unused discard pattern".into(),
+                    text: format!("_ as {name} can be written more concisely as {name}"),


Suggested change

text: format!("_ as {name} can be written more concisely as {name}"),

text: format!("_ as {name} can be written more concisely as {name}"),

Suggested change

text: format!("_ as {name} can be written more concisely as {name}"),

text: format!("`_ as {name}` can be written more concisely as `{name}`"),

eutampieri · 2025-06-18T11:42:59Z

Thanks @giacomocavalieri and @lpil for your support!

lpil

Thank you!!

lpil · 2025-06-22T14:47:16Z

Oops, tests are failing. Could you rebase to remove the merge commits also please 🙏

giacomocavalieri · 2025-06-27T19:36:58Z

Hello Eugenio, is this ready for review? Remember to un-draft it when it is!

eutampieri · 2025-06-28T06:18:53Z

Hi @giacomocavalieri, no, it’s not. It's still failing the tests.

eutampieri · 2025-06-28T06:54:01Z

We're failing cargo clippy here, though it seems it's failing in some other part of the codebase

eutampieri · 2025-06-28T06:57:17Z

@lpil I could try cargo clippy --workspace --fix, but I think it would add a lot of noise (here's my CI run)

And here are the changes:

compiler-core/src/config.rs
compiler-core/src/docs.rs
compiler-core/src/error/tests.rs
compiler-core/src/language_server/tests/action.rs
compiler-core/src/language_server/tests/completion.rs
compiler-core/src/language_server/tests/reference.rs
compiler-core/src/type_/tests.rs

GearsDatapacks · 2025-06-28T07:30:45Z

The latest commit on main should have fixed the clippy lints, unless you introduced more in this PR. If you rebase on main now, they should all pass

eutampieri · 2025-07-01T08:38:12Z

@GearsDatapacks @lpil rebased

lpil

Thank you!! Few tiny notes

lpil · 2025-07-03T16:45:21Z

...re/src/type_/tests/snapshots/gleam_core__type___tests__warnings__unused_discard_pattern.snap

+  ┌─ /src/warning/wrn.gleam:4:10
+  │
+4 │     _ as b -> b
+  │          ^


Suggested change

│ ^

│ ^^^^^^

Can we make the arrow point to the whole thing that would be replaced please 🙏

This hasn't been done yet 🙏

CHANGELOG.md

lpil · 2025-07-03T16:46:17Z

compiler-core/src/warning.rs

+                        },
+                        extra_labels: vec![],
+                    }),
+                    hint: Some(format!("Replace with {name}")),


Let's drop the hint as the text covers it pretty much

This hasn't been done yet!

I know, sorry... I just had a lot of things to do. Will fix this evening

…ern test

eutampieri marked this pull request as draft June 13, 2025 14:04

eutampieri marked this pull request as ready for review June 13, 2025 15:51

lpil approved these changes Jun 17, 2025

View reviewed changes

eutampieri requested a review from lpil June 18, 2025 14:50

lpil approved these changes Jun 22, 2025

View reviewed changes

lpil marked this pull request as draft June 22, 2025 14:47

eutampieri force-pushed the main branch from df12797 to 4f8dacc Compare June 26, 2025 08:31

eutampieri marked this pull request as ready for review June 28, 2025 06:58

eutampieri requested a review from lpil June 28, 2025 06:58

eutampieri force-pushed the main branch from 82bd1b5 to d17bb41 Compare July 1, 2025 08:37

lpil reviewed Jul 3, 2025

View reviewed changes

lpil marked this pull request as draft July 7, 2025 12:55

eutampieri added 8 commits July 7, 2025 20:11

Emit a warning for _ as x

06a71a6

Have the formatter rewrite _ as y to y

e921baf

Emit a warning for the deprecation of _ as a syntax

b68c483

Revert whitespace removal

befe32e

Add test for unused discard pattern

7421784

Add test for the rewrite of unused discard patterns

07acc13

Add newline at the end of the test string for the unused_discard_patt…

0ac426c

…ern test

Update CHANGELOG

d09abe3

eutampieri added 6 commits July 7, 2025 20:11

Move changelog item to the relevant section

fa0a528

Address review comment: better diagnostics

330f2b5

Remove dead code

f2cfb83

Run cargo fmt

f45e8cb

Update snapshot for unused discard pattern test

a7c1415

Various fixes

d107610

eutampieri force-pushed the main branch from 9f64d9a to d107610 Compare July 7, 2025 18:11

Fix CHANGELOG formatting

7aad711

eutampieri requested a review from lpil July 7, 2025 18:13

eutampieri marked this pull request as ready for review July 7, 2025 18:13

	text: format!("_ as {name} can be written more concisely as {name}"),
	text: format!("_ as {name} can be written more concisely as {name}"),

	text: format!("_ as {name} can be written more concisely as {name}"),
	text: format!("`_ as {name}` can be written more concisely as `{name}`"),

Uh oh!

Deprecate _ as x patterns #4683

Are you sure you want to change the base?

Deprecate _ as x patterns #4683

Uh oh!

Conversation

eutampieri commented Jun 13, 2025

Uh oh!

giacomocavalieri commented Jun 13, 2025

Uh oh!

eutampieri commented Jun 13, 2025

Uh oh!

lpil left a comment

Choose a reason for hiding this comment

Uh oh!

lpil Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

eutampieri Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

eutampieri commented Jun 18, 2025

Uh oh!

lpil left a comment

Choose a reason for hiding this comment

Uh oh!

lpil commented Jun 22, 2025

Uh oh!

giacomocavalieri commented Jun 27, 2025

Uh oh!

eutampieri commented Jun 28, 2025

Uh oh!

eutampieri commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eutampieri commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GearsDatapacks commented Jun 28, 2025

Uh oh!

eutampieri commented Jul 1, 2025

Uh oh!

lpil left a comment

Choose a reason for hiding this comment

Uh oh!

lpil Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

lpil Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lpil Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

lpil Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

eutampieri Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eutampieri commented Jun 28, 2025 •

edited

Loading

eutampieri commented Jun 28, 2025 •

edited

Loading