test: add a case of 'general newilne' #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking support for multiple \R, the "general newline" shorthand https://github.com/kkos/oniguruma/blob/3bbb3d65c65350bfd941129592cb390aadedb25a/doc/SYNTAX.md#23-onig_syn_op2_esc_capital_r_general_newline-enable-r
|
History re-written with a simpler example. I've also confirmed that exactly the same test passes 🟢 upstream. |
|
This seems to be cause by a 🐞 upstream that was fixed on the latest master 2 days ago kkos/oniguruma#284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking support for \R, the "general newline" shorthand syntax.
This case seems to be causing Oniguruma CI failures on go-enry/go-enry#161 🙄
From what I can see upstream, that should work with our defaults of
OnigDefaultSyntax(that should be OnigSyntaxOniguruma).See https://regex101.com/r/kKIyO6/1 and https://rubular.com/r/TdFmiV6PUDG3Ya for examples that match on a fixture from clsDataPack.cls.