refactor: extract helper functions from SearchIssues #36158
+93
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the SearchIssues function into smaller, more maintainable pieces: - parseIssueIsClosed: parses "state" query parameter - parseIssueIsPull: parses "type" query parameter - buildSearchIssuesRepoIDs: builds repository IDs list for search This improves code readability and makes the logic easier to test and reuse. Ref: go-gitea#35015
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
Replace fmt.Errorf with errors.New for better performance as suggested by perfsprint linter.
lunny
reviewed
Dec 17, 2025
| if err != nil { | ||
| repoIDs, allPublic, err := buildSearchIssuesRepoIDs(ctx) | ||
| if err != nil { | ||
| if user_model.IsErrUserNotExist(err) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
SearchIssuesfunction inrouters/api/v1/repo/issue.goby extracting common logic into reusable helper functions:parseIssueIsClosed(): Parses the "state" query parameter and returns the correspondingisClosedoptionparseIssueIsPull(): Parses the "type" query parameter and returns the correspondingisPulloptionbuildSearchIssuesRepoIDs(): Builds the list of repository IDs for issue search based on query parametersBenefits:
Changes:
SearchIssuesfunctionTest plan
/repos/issues/searchendpointRef: #35015