Skip to content

Conversation

@sinomoe
Copy link
Contributor

@sinomoe sinomoe commented Nov 8, 2024

canal:

  • address format support ipv6 with port like [::1]:3306 in canal
  • parse ipv6 address with optional port like ::1 or [::1]:3306 in dumper

Copy link
Collaborator

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try to support things like :3307 (e.g. only a port, not a host)? And maybe have a default port number if none is specified? (eg. ::1)

@dveeden
Copy link
Collaborator

dveeden commented Nov 8, 2024

What about tests and CI? Anything we can do to test this and/or make it easier to test?

@sinomoe
Copy link
Contributor Author

sinomoe commented Nov 8, 2024

Should we try to support things like :3307 (e.g. only a port, not a host)? And maybe have a default port number if none is specified? (eg. ::1)

As a client tool for MySQL, I think the host of the MySQL server should be clearly specified.

@sinomoe sinomoe marked this pull request as draft November 8, 2024 11:21
@sinomoe sinomoe force-pushed the feat/ipv6 branch 2 times, most recently from b9797d3 to 7c5a140 Compare November 8, 2024 12:05
@sinomoe sinomoe marked this pull request as ready for review November 8, 2024 12:07
@sinomoe
Copy link
Contributor Author

sinomoe commented Nov 8, 2024

What about tests and CI? Anything we can do to test this and/or make it easier to test?

Test cases and CI have been completed.

Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal @dveeden

@lance6716 lance6716 merged commit 760b566 into go-mysql-org:master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants