server: take in context as parameter to error handlers #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contexts are frequently used to store request-specific metadata, such as logging, metrics and tracing information. Error handlers configured by the user are much more useful if they have this information available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexts are frequently used to store request-specific metadata, such as logging, metrics and tracing information. Error handlers configured by the user are much more useful if they have this information available.
This is a breaking change, which is unfortunate. Not sure what the policy is for breaking changes in this project. This functionality could also be implemented as more verbose, non-breaking changes where we deprecate the error handlers that don't take a context, and add new error handlers that do.
If this project is doing a breaking change, it'd be a good idea to look into other potential candidates for taking in context parameters.