Skip to content

Net pong: Fix public IP getter link #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wjtaylor-games wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Net pong: Fix public IP getter link #17

wjtaylor-games wants to merge 2 commits into from

Conversation

@wjtaylor-games
Copy link

@wjtaylor-games wjtaylor-games commented Dec 12, 2025

Would resolve #16

Bromeon
Bromeon requested changes Dec 13, 2025
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know that the domain canhazip.com is trustworthy? I don't want to expose users to potential telemetry collection or worse. Godot uses a different one.

@wjtaylor-games
Copy link
Author

wjtaylor-games commented Dec 13, 2025

Oh, should it instead be icanhazip.com ? That one I think is the standard

@wjtaylor-games
Update public IP link address
ef76785 
icanhazip.com instead of canhazip.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bromeon Bromeon Bromeon requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The "Find your public IP address" LinkButton in Net Pong has no URI

2 participants

@wjtaylor-games @Bromeon