Skip to content

Replace remaining uses of shorthand codeblock syntax, add CI check #11046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Replace remaining uses of shorthand codeblock syntax, add CI check #11046

merged 1 commit into from
Jul 25, 2025

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev force-pushed the prohibit-shorthand-codeblock branch from bc91067 to 1c15870 Compare June 23, 2025 07:04
skyace65
skyace65 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts will need to be resolved by a merge but I'm fine with the changes removing shorthand.

@mhilbrunner could you take a look at the CI check?

@skyace65 skyace65 added content:website Issues related to adding website features and fixing bugs, whether on the front or back-end area:manual Issues and PRs related to the Manual/Tutorials section of the documentation area:contributing Issues and PRs related to the Contributing/Development section of the documentation labels Jul 25, 2025
mhilbrunner
mhilbrunner approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added CI code looks good to me, assuming the grep command is correct, haven't tested it locally.

@skyace65 skyace65 force-pushed the prohibit-shorthand-codeblock branch from 1c15870 to 3946ede Compare July 25, 2025 20:20
@skyace65
Copy link
Contributor

Resolved merge conflicts

@skyace65 skyace65 merged commit c30bf8f into godotengine:master Jul 25, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:website Issues related to adding website features and fixing bugs, whether on the front or back-end enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexeev @skyace65 @mhilbrunner