Update descriptions of AHashMap and HashMap. Recommend AHashMap over HashMap by default.
#11123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
enhancement
area:contributing
mhilbrunner
approved these changes
Jul 24, 2025
… over `HashMap` by default.
Ivorforce
force-pushed
the
ahashmap-default
branch
from
f57548a to
bc71be5
Compare
skyace65
approved these changes
Jul 25, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Will need to go through a core meeting before this can be merged. (Edit: Approved in core meeting)
AHashMapis way faster thanHashMapin nearly all circumstances.HashMapon the other hand has some 'defensive' affordances built in. However, these affordances are not expected for C++ map types: Nostdmap type grants these, probably because they are what makesHashMapso slow. In addition, most users of map types do not need these affordances.In the interest of performance, this changes the recommended map type to
AHashMap.