-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add missing feature tags threads
and nothreads
in documentation table
#11130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
skyace65
merged 1 commit into
godotengine:master
from
leandro-benedet-garcia:tags-update
Jul 24, 2025
Merged
Add missing feature tags threads
and nothreads
in documentation table
#11130
skyace65
merged 1 commit into
godotengine:master
from
leandro-benedet-garcia:tags-update
Jul 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
reviewed
Jul 21, 2025
146c06d
to
4cf2511
Compare
dsnopek
reviewed
Jul 21, 2025
4cf2511
to
46a9ec9
Compare
threads
and nothreads
in documentation tablethreads
and nothreads
in documentation table
Calinou
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Ivorforce
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only got debatable nitpicks, looks good to me :)
46a9ec9
to
97f5aad
Compare
skyace65
approved these changes
Jul 24, 2025
Thanks! And congrats on your first merged PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:manual
Issues and PRs related to the Manual/Tutorials section of the documentation
cherrypick:4.3
cherrypick:4.4
enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag
nothread
was added by godotengine/godot#93563, however this table does not have both threads tags, this PR addsthreads
andnothreads
to it.This PR also adds a note to the gdextension tutorial explaining the order of operation and how they should work.
Discussion about the subject in rocket chat in this link: https://chat.godotengine.org/channel/gdextension/thread/kkLYt23hP93n2xvtP