Skip to content

Add missing feature tags threads and nothreads in documentation table #11130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

leandro-benedet-garcia
Copy link
Contributor

@leandro-benedet-garcia leandro-benedet-garcia commented Jul 21, 2025

The tag nothread was added by godotengine/godot#93563, however this table does not have both threads tags, this PR adds threads and nothreads to it.

This PR also adds a note to the gdextension tutorial explaining the order of operation and how they should work.

Discussion about the subject in rocket chat in this link: https://chat.godotengine.org/channel/gdextension/thread/kkLYt23hP93n2xvtP

@leandro-benedet-garcia leandro-benedet-garcia changed the title Aded missing feature tags threads and nothreads in documentation table Add missing feature tags threads and nothreads in documentation table Jul 21, 2025
@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.4 labels Jul 21, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got debatable nitpicks, looks good to me :)

@skyace65 skyace65 merged commit 471ad88 into godotengine:master Jul 24, 2025
1 check failed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 cherrypick:4.4 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants