cmd/go: modload should use a read-write lock to improve concurrency #74311

AdallomRoy · 2025-06-20T10:27:03Z

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

google-cla · 2025-06-20T10:27:07Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2025-06-22T12:37:29Z

This PR (HEAD: 6ad6f6a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/683215.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-22T12:43:56Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-22T12:50:17Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T19:08:44Z

Message from Roy Reznik:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T19:08:44Z

Message from Roy Reznik:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-27T15:32:59Z

Message from Michael Matloob:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-27T15:40:08Z

Message from Michael Matloob:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-27T15:40:09Z

Message from Michael Matloob:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-07T16:10:07Z

Message from Roy Reznik:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-07T16:24:04Z

Message from Michael Matloob:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-31T21:17:08Z

Message from Michael Matloob:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-31T21:17:09Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-31T21:06:18Z","revision":"8018be87c195ef01b6104e2ae67c7a4e274ff334"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-31T21:53:37Z

Message from Michael Matloob:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-31T21:53:38Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-31T21:53:38Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T17:33:39Z

Message from Ian Alexander:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T17:48:45Z

Message from Michael Matloob:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T17:48:46Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-01T17:37:46Z","revision":"8018be87c195ef01b6104e2ae67c7a4e274ff334"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:11:46Z

Message from Michael Matloob:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:11:47Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64-longtest has failed with summary (view all results):

go on master (change 683215)

To reproduce, try gomote repro 8707718139872777169.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:11:47Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:11:48Z

Message from Michael Matloob:

Patch Set 2: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:11:48Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-01T18:01:15Z","revision":"4a2ef5e555c1846a3b22f50bfd1177423860baaf"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:49:25Z

Message from Michael Matloob:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:49:26Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-08-01T18:49:26Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683215.
After addressing review feedback, remember to publish your drafts!

This PR will be imported into Gerrit with the title and first comment (this text) used to generate the subject and body of the Gerrit change. Change-Id: I3f9bc8a2459059a924a04fa02794e258957819b5 GitHub-Last-Rev: 6ad6f6a GitHub-Pull-Request: #74311 Reviewed-on: https://go-review.googlesource.com/c/go/+/683215 Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Ian Alexander <jitsu@google.com> Reviewed-by: Michael Matloob <matloob@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2025-08-01T19:03:48Z

This PR is being closed because golang.org/cl/683215 has been merged.

AdallomRoy force-pushed the master branch from dc4c1d7 to 18b4a91 Compare June 22, 2025 12:27

cmd/go: modload should use a read-write lock to improve concurrency

6ad6f6a

AdallomRoy force-pushed the master branch from 18b4a91 to 6ad6f6a Compare June 22, 2025 12:31

gopherbot closed this Aug 1, 2025

cmd/go: modload should use a read-write lock to improve concurrency #74311

cmd/go: modload should use a read-write lock to improve concurrency #74311

Conversation

AdallomRoy commented Jun 20, 2025

Uh oh!

google-cla bot commented Jun 20, 2025

Uh oh!

gopherbot commented Jun 22, 2025

Uh oh!

gopherbot commented Jun 22, 2025

Uh oh!

gopherbot commented Jun 22, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 27, 2025

Uh oh!

gopherbot commented Jun 27, 2025

Uh oh!

gopherbot commented Jun 27, 2025

Uh oh!

gopherbot commented Jul 7, 2025

Uh oh!

gopherbot commented Jul 7, 2025

Uh oh!

gopherbot commented Jul 31, 2025

Uh oh!

gopherbot commented Jul 31, 2025

Uh oh!

gopherbot commented Jul 31, 2025

Uh oh!

gopherbot commented Jul 31, 2025

Uh oh!

gopherbot commented Jul 31, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

gopherbot commented Aug 1, 2025

Uh oh!

Uh oh!