cmd/compile: fix loclist for heap return vars without optimizations #74398

derekparker · 2025-06-26T23:43:31Z

When compiling without optimizations certain variables such as
return params end up missing location lists.

When compiling without optimizations certain variables such as return params end up missing location lists. Fixes golang#65405

gopherbot · 2025-06-26T23:48:14Z

This PR (HEAD: 7bbed4f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-26T23:54:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-27T16:16:05Z

Message from Derek Parker:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-30T03:33:44Z

This PR (HEAD: 1af2fc8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-30T03:46:12Z

This PR (HEAD: 994b9b0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-30T23:11:13Z

Message from Keith Randall:

Patch Set 4: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-30T23:11:14Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-06-30T22:56:32Z","revision":"2ceedc341ccb11b5085ba0d4fd0d94ffc5c7f6b5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-30T23:17:53Z

Message from Keith Randall:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-30T23:17:54Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-windows-386. Summary (view all results):

go on master (change 684377)

To reproduce, try gomote repro 8710597194025991793.

Additional links for debugging:

go tool dist test -json output [shard 4]

golang/try/gotip-windows-amd64. Summary (view all results):

go on master (change 684377)

To reproduce, try gomote repro 8710597194025991777.

Additional links for debugging:

go tool dist test -json output [shard 2]

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-30T23:17:54Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-01T20:48:46Z

Message from Derek Parker:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-07T14:25:59Z

Message from Than McIntosh:

Patch Set 4: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-10T22:54:05Z

This PR (HEAD: a7fbf3c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-10T23:00:34Z

Message from Derek Parker:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T15:44:39Z

Message from Derek Parker:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:38:47Z

Message from Keith Randall:

Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:38:48Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-22T16:28:47Z","revision":"de9b9959960957fe47a062a56914ded36553718e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:38:49Z

Message from Keith Randall:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:46:35Z

Message from Keith Randall:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:46:36Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

go on master (change 684377)

To reproduce, try gomote repro 8708628455004388881.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T16:46:36Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:01:23Z

Message from Keith Randall:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:09:12Z

This PR (HEAD: 6257d77) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-22T17:16:46Z

Message from Derek Parker:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:31:53Z

Message from Keith Randall:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:31:54Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-22T17:26:04Z","revision":"f3e955daa10538bc794e91531b626617d15691bd"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:47:23Z

Message from Keith Randall:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:47:24Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

go on master (change 684377)

To reproduce, try gomote repro 8708624853022689361.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T17:47:25Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T18:40:36Z

This PR (HEAD: f18d459) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-22T18:48:41Z

This PR (HEAD: b3fe823) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-22T18:56:10Z

Message from Derek Parker:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T19:54:39Z

Message from Keith Randall:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T19:54:39Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-22T19:45:52Z","revision":"a9cf94acfdf1e254615346b9ed321e319a678b17"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T20:09:58Z

Message from Keith Randall:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T20:09:59Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

go on master (change 684377)

To reproduce, try gomote repro 8708616049821143057.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T20:10:00Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T22:05:12Z

This PR (HEAD: 5ab6a53) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/684377.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-22T22:19:27Z

Message from Keith Randall:

Patch Set 9: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T22:26:48Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-22T22:09:33Z","revision":"bf0de064b40d7ba46d2b8d6df538c92453ac1e7a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T22:40:33Z

Message from Keith Randall:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T22:40:34Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T22:40:34Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T23:08:10Z

Message from Keith Randall:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-22T23:08:11Z

Message from Keith Randall:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-23T02:29:14Z

Message from Michael Knyszek:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/684377.
After addressing review feedback, remember to publish your drafts!

When compiling without optimizations certain variables such as return params end up missing location lists. Fixes #65405 Change-Id: Id4ec6b1ab6681fd77b8fefb47a4ec05060c128ef GitHub-Last-Rev: 5ab6a53 GitHub-Pull-Request: #74398 Reviewed-on: https://go-review.googlesource.com/c/go/+/684377 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com>

gopherbot · 2025-07-23T03:14:38Z

This PR is being closed because golang.org/cl/684377 has been merged.

cmd/compile: fix loclist for heap return vars without optimizations

7bbed4f

When compiling without optimizations certain variables such as return params end up missing location lists. Fixes golang#65405

cmd/link: cleanup test

1af2fc8

cmd/link: remove unnecessary break in loop in test

994b9b0

derekparker added 2 commits July 10, 2025 15:19

cmd/compile: prefer base.Fatalf over panic

cccfbc0

cmd/link: update test to be less specific to net.sendFile

a7fbf3c

cmd/link: ignore reflect package in TestDWARFLocationList

6257d77

cmd/link: ignore syscall.compileCallback on windows

f18d459

cmd/link: ignore 2 specific functions due to linkname

b3fe823

cmd/link: skip syscall in test on windows

5ab6a53

gopherbot closed this Jul 23, 2025

cmd/compile: fix loclist for heap return vars without optimizations #74398

cmd/compile: fix loclist for heap return vars without optimizations #74398

Uh oh!

Conversation

derekparker commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jun 26, 2025

Uh oh!

gopherbot commented Jun 26, 2025

Uh oh!

gopherbot commented Jun 27, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jun 30, 2025

Uh oh!

gopherbot commented Jul 1, 2025

Uh oh!

gopherbot commented Jul 7, 2025

Uh oh!

gopherbot commented Jul 10, 2025

Uh oh!

gopherbot commented Jul 10, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

Uh oh!

gopherbot commented Jul 22, 2025

derekparker commented Jun 26, 2025 •

edited

Loading