Skip to content

fix(example-application): use throw instead of (missing) reject #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(example-application): use throw instead of (missing) reject #140

wants to merge 2 commits into from

Conversation

rluvaton
Copy link
Collaborator

No description provided.

@mikicho
Copy link

mikicho commented May 22, 2022 •
edited
Loading

More info about reject vs throw
https://www.facebook.com/groups/jsisrael/posts/5212256798817956/

@rluvaton
Copy link
Collaborator Author

rluvaton commented May 23, 2022 •
edited
Loading

Thanks, but we don't have the reject function in this context

Hence the missing in the title 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikicho mikicho mikicho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rluvaton @mikicho