Skip to content

fix: Incorrect token count mapping in telemetry #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: Incorrect token count mapping in telemetry #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4590843
fix: Use candidates_token_count for output tokens in telemetry
tl-nguyen Jul 22, 2025
9ee4510
Merge branch 'main' into fix-telemetry-token-count-mapping
ankursharmas Jul 24, 2025
7f07482
Merge branch 'main' into fix-telemetry-token-count-mapping
ankursharmas Jul 24, 2025
3d043f5
Merge branch 'main' into fix-telemetry-token-count-mapping
ankursharmas Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def trace_call_llm(
)
span.set_attribute(
'gen_ai.usage.output_tokens',
llm_response.usage_metadata.total_token_count,
llm_response.usage_metadata.candidates_token_count,
)


Expand Down
6 changes: 4 additions & 2 deletions tests/unittests/test_telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,17 @@ async def test_trace_call_llm_usage_metadata(monkeypatch, mock_span_fixture):
llm_response = LlmResponse(
turn_complete=True,
usage_metadata=types.GenerateContentResponseUsageMetadata(
total_token_count=100, prompt_token_count=50
total_token_count=100,
prompt_token_count=50,
candidates_token_count=50,
),
)
trace_call_llm(invocation_context, 'test_event_id', llm_request, llm_response)

expected_calls = [
mock.call('gen_ai.system', 'gcp.vertex.agent'),
mock.call('gen_ai.usage.input_tokens', 50),
mock.call('gen_ai.usage.output_tokens', 100),
mock.call('gen_ai.usage.output_tokens', 50),
]
assert mock_span_fixture.set_attribute.call_count == 9
mock_span_fixture.set_attribute.assert_has_calls(
Expand Down