fix: eval module not found exception string #2148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangfei
approved these changes
Jul 24, 2025
hangfei
added
the
ready to pull
|
Thanks for the fix. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
Merge #2148 This PR fixes #2071 exception string from `pip install google-adk[eval]` to `pip install "google-adk[eval]"` which makes it compatible for all the bash, zsh and other terminals COPYBARA_INTEGRATE_REVIEW=#2148 from kavinkumar807:fix-module-not-found-exception-string-in-eval 9142810 PiperOrigin-RevId: 786752261
|
Merged. thanks for the fix! |
pandasanjay
pushed a commit
to pandasanjay/adk-python
that referenced
this pull request
Jul 28, 2025
Merge google#2148 This PR fixes google#2071 exception string from `pip install google-adk[eval]` to `pip install "google-adk[eval]"` which makes it compatible for all the bash, zsh and other terminals COPYBARA_INTEGRATE_REVIEW=google#2148 from kavinkumar807:fix-module-not-found-exception-string-in-eval 9142810 PiperOrigin-RevId: 786752261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2071 exception string from
pip install google-adk[eval]topip install "google-adk[eval]"which makes it compatible for all the bash, zsh and other terminals