-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature/nvidia nim integration #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/nvidia nim integration #3433
Conversation
|
Response from ADK Triaging Agent Hello @soumilinandi, thank you for creating this PR! To help us review your contribution more effectively, could you please address the following points from our contribution guidelines:
This information is crucial for our reviewers to understand and verify your changes. You can find more details in our CONTRIBUTING.md. Thanks! |
|
We'd love to accept this contribution. When it's ready, let us know and we can merge. |
|
@hangfei This PR is ready for review, thanks for taking a look before! I don't think it requires any new tests since it's just an example but let me know if anything is needed. |
Problem:
Currently there are no examples on how to integrate with NVIDIA NIMS
Solution:
Since NVIDIA has already built a nim connector with LiteLLM, and Google ADK directly adds LiteLLM, we showcase an example of how to use
nvidiamodels using LiteLLM connectorTesting Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Checklist
Additional context
Add any other context or screenshots about the feature request here.