Add CertBySHA1Hash to retrieve a specific cert #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurv15
reviewed
Sep 23, 2025
certtostore_windows.go
Outdated
|
|
||
| var certContext *windows.CertContext | ||
| var cert *x509.Certificate | ||
| for { |
Contributor
There was a problem hiding this comment.
We don't need a for loop for this search as we can ever have just 1 cert with a given SHA.
Author
There was a problem hiding this comment.
Thanks, you're right. I fixed it now in the recent commit.
Signed-off-by: Boris Djurdjevic <boris@djurdjevic.ch>
apurv15
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR implements retrieving a certificate by its SHA1 hash.
It is useful in situations where
CertByCommonNamecannot determine the correct certificate because there are multiple certificates with the same CN (e.g., one for client auth and one for server auth).In combination with
ListCertificatesfrom #88, users can process each certificate to identify the desired one and obtain thewindows.CertContextfor a specific certificate.