Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Removed message from required export keys #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed message from required export keys #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebc0de
Removed message from required export keys
lorenzbaum Feb 1, 2018
19a4cad
Removed message from required keys. Tests fixed
lorenzbaum Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/MessageSink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const errors = require('./MessageSink/errors.js');
const MSG_CREATE_EXPORT_KEYS = ['api_key', 'user_id', 'type', 'time_stamp',
'platform', 'message', 'intent', 'version', 'response_time', 'custom_session_id'];
const REQUIRED_MSG_CREATE_EXPORT_KEYS = ['api_key', 'type', 'user_id',
'time_stamp', 'platform', 'message'];
'time_stamp', 'platform'];
const MSG_UPDATE_EXPORT_KEYS = ['api_key', 'message_id', 'intent',
'feedback', 'version'];
const REQUIRED_MSG_UPDATE_EXPORT_KEYS = ['api_key', 'message_id'];
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/MessageSink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ test('validateCreateManifest should return false on a new instance', t => {
test('validateCreateManifest should return true when all required string are set', t => {
inst.api_key = STUB;
inst.user_id = STUB;
t.is(inst.setPlatform(STUB).setMessage(STUB).validateCreateManifest(), true);
t.is(inst.setPlatform(STUB).validateCreateManifest(), true);
});

test('validateUpdateManifest should return false on an instance with api_key and message_id set', t => {
Expand Down