Skip to content

fix pattern matching exercise solution #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −12
Open

fix pattern matching exercise solution #2949

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfd7b7e
fix pattern matching exercise solution ,my solution works on more com…
mustafapc Oct 18, 2025
1d86274
Refactor eval function and update Operation enum
mustafapc Oct 18, 2025
e1bbe8b
Implement PartialEq for Operation enum
mustafapc Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/pattern-matching/exercise.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
// ANCHOR: Operation
/// An operation to perform on two subexpressions.
#[derive(Debug)]
#[derive(PartialEq)]
enum Operation {
Add,
Sub,
Expand All @@ -40,18 +41,13 @@ enum Expression {
// ANCHOR: eval
fn eval(e: Expression) -> i64 {
// ANCHOR_END: eval
match e {
Expression::Op { op, left, right } => {
let left = eval(*left);
let right = eval(*right);
match op {
Operation::Add => left + right,
Operation::Sub => left - right,
Operation::Mul => left * right,
Operation::Div => left / right,
}
}
Expression::Value(v) => v,
match e{
Expression::Op{op: a, left: b, right: c} if a == Operation::Add => return eval(*b) + eval(*c),
Expression::Op{op: a, left: b, right: c} if a == Operation::Sub => return eval(*b) - eval(*c),
Expression::Op{op: a, left: b, right: c} if a == Operation::Mul => return eval(*b) * eval(*c),
Expression::Op{op: a, left: b, right: c} if a == Operation::Div => return eval(*b) / eval(*c),
Expression::Value(a) => return a,
_ => return 0,
}
}

Expand Down