Skip to content

Internal change #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 9, 2025
Merged

Internal change #2579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions protobuf/compiler/src/google/protobuf/compiler/j2objc/j2objc_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ const std::set<absl::string_view> kKeywords = {
"virtual", "void", "volatile", "while",
};


absl::string_view FieldName(const FieldDescriptor *field) {
// Groups are hacky: The name of the field is just the lower-cased name
// of the group type. In Java, though, we would like to retain the original
Expand Down Expand Up @@ -765,6 +766,7 @@ bool IsGenerateFileDirMapping() {
}

bool IsGenerateProperties(const FileDescriptor *file) {

// Check for the "j2objc_package_prefix" option using unknown fields so we
// don't have to pre-build j2objc-descriptor.pb.[h|cc].
const UnknownField *generate_properties_field =
Expand Down