Added version tagging for master commits #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would still really like to either get this in or if the maintainers would rather this be handled in a different way implement this or some other method of tracking changes in master branch in a different way as there's activity going on in the repo but still no way to track it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is extremely difficult to audit changes in this repository due to the fact that there is no sort of tagging when code is committed to the master branch of this repository. Therefore there is no way to know what exact version of ngx_brotli your using when downloading from GitHub unless you use a SHA of some sort, which is unwieldy.
Therefore this PR adds a GitHub Action to update a tag on the repo every time a commit is made to master. That way there is a tag to reference on each change in master, allowing for easier audibility of the repository.
Also resolves issues pointed out around tagging in Issue #120.
This is also a re-submission of PR #141 because I messed up the commit history and it was much cleaner to redo it.