[Feature] Allow Users to setBufferSizeInFrames when in PCM Offload Mode #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwu1
approved these changes
Dec 18, 2025
flamme
reviewed
Dec 18, 2025
|
|
||
| // If the requested size is 0 (Default/Auto), use the maximum capacity. | ||
| if (targetFrames <= 0) { | ||
| targetFrames = mAudioStream->getBufferCapacityInFrames(); |
Collaborator
There was a problem hiding this comment.
Please do not use maximum. If the value is not valid, just return failure.
| ) | ||
|
|
||
| Text( | ||
| text = if (!isPlaying) { |
Collaborator
There was a problem hiding this comment.
The buffer size can also be set while actively playing.
flamme
reviewed
Dec 18, 2025
| } | ||
|
|
||
| // Determine target size: Use maximum capacity if 0 or less is requested. | ||
| const int32_t capacity = mAudioStream->getBufferCapacityInFrames(); |
| value = sliderPosition, | ||
| onValueChange = { newValue -> | ||
| sliderPosition = newValue | ||
| requestedFrames.intValue = (sliderPosition * sampleRate).toInt() |
Collaborator
There was a problem hiding this comment.
This should limit to the buffer capacity instead of sample rate. The buffer size for PCM offload can be more than 1 second.
flamme
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds the ability for the user to use the
setBufferSizeInFramesmethod to allow for them to adjust the buffer size during PCM offload.