feat: Enable dynamic subdirectory recording paths in the test server #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkt74
approved these changes
Sep 15, 2025
sdks/python/sample/test_sample.py
Outdated
| print("[PyTest] Making request to test-server proxy for www.github.com...") | ||
|
|
||
| custom_headers = { | ||
| 'Test-Name': 'models/python-sample-test', |
Collaborator
There was a problem hiding this comment.
could you add a test for multiple layers? e.g., foo/bar/test-name
Collaborator
Author
There was a problem hiding this comment.
Updated, now we have test with just a single file name and name with path
wanlin31
force-pushed
the
include_path
branch
from
be4a25a to
674210b
Compare
wanlin31
force-pushed
the
include_path
branch
from
674210b to
a8938e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to accommodate the Python test suite's recording file directory structure.
Currently, our ~2000 Python tests organize recordings into module-specific subfolders. This structure is critical for maintainability and makes it easier to locate specific recording files.
To reduce test overhead and avoid duplicate pytest configurations, we use a single, session-scoped test server. The problem is that this server only accepts one root record_dir configuration when it starts, which would result in all 2,000 recordings being saved into one flat directory.
This pr implementing the logic needed for the single-session server to correctly generate test recordings into their appropriate, module-specific subdirectories.
Behavior:
Tested with the python test-server sample, attached the change.