Skip to content

Conversation

W0ngL1
Copy link
Contributor

@W0ngL1 W0ngL1 commented Nov 4, 2024

Hi @tooryx,

This PR is about #392 .

The grafana team started to build docker images from 9 years ago, the first version which has a official docker is 2.1.3, but some versions are not available now. So the actual fingerprints covers 348 versions, from 2.1.3(9 years ago) to the latest 11.3.0(2024.10.23).

And I'll update .binproto file soon today.

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 4, 2024

Hi @tooryx, I cannot upload grafana.binproto (about 182MB) because of the github policy. So I used git-lfs to track it, but it seems I cannot upload it to public fork, can you fix it or upload it?

This is the link of grafana.binproto.
https://drive.google.com/file/d/1BwKc_msEiKfF4NfxM1X1J78fjpAPQuWp/view?usp=sharing

This is returns of Github Desktop.

batch response: @W0ngL1 can not upload new objects to public fork W0ngL1/tsunami-security-scanner-plugins
error: failed to push some refs to 'https://github.com/W0ngL1/tsunami-security-scanner-plugins.git'

@tooryx
Copy link
Member

tooryx commented Nov 18, 2024

Hi @W0ngL1,

I will try to think about a solution. I will let you know.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 18, 2024

Hi @tooryx, copy that.

And I think you or your teammates can upload this file manually, the community developers have no need to get git-lfs privileges.

@tooryx
Copy link
Member

tooryx commented Nov 21, 2024

Hi @W0ngL1,

For now, please just remove the LFS attribute. When we review this change, I will regenerate the signatures internally and that should solve this issue.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Nov 21, 2024

Hi @tooryx,

I've removed lfs attribute, please check it if you're free.

@giacomo-doyensec
Copy link
Collaborator

LGTM - Approved
@maoning you can merge after regenerating the .binproto

Reviewer: Giacomo, Doyensec

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented May 7, 2025

Hi there, is there any progress on this issue?

@tooryx tooryx linked an issue Jul 25, 2025 that may be closed by this pull request
@tooryx
Copy link
Member

tooryx commented Jul 25, 2025

Hi @W0ngL1,

I will have to come-up with a good solution to integrate this change and this might take a while. Apologies for this.
So in the meantime, you are allowed to pick a another contribution.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Jul 25, 2025

Hi @W0ngL1,

I will have to come-up with a good solution to integrate this change and this might take a while. Apologies for this. So in the meantime, you are allowed to pick a another contribution.

~tooryx

@tooryx Copy that. Could I pick this one #498?

@tooryx
Copy link
Member

tooryx commented Jul 25, 2025

I will discuss with the rest of the team and let you know.

~tooryx

@tooryx
Copy link
Member

tooryx commented Sep 5, 2025

Hi @W0ngL1,

We are still seeing how to handle this contribution.
We will prioritize #498 in the meantime.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Sep 5, 2025

Hi @tooryx,

Copy that.

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Sep 5, 2025

Hi @tooryx,

Can I start another issue, cause #498 is merged.

@tooryx
Copy link
Member

tooryx commented Sep 5, 2025

I have marked your other propositions for review. We will let you know once the panel decided on the next one.
Feel free to suggest more contribution as well.

~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Sep 8, 2025

Thanks @tooryx.

@tooryx
Copy link
Member

tooryx commented Oct 2, 2025

Hi @W0ngL1,

Could you please trim down the number of supported version for now? Let's add only version 8 through 11 for now.
Once I have a more long term solution for this issue we can revisit.

Thank you,
~tooryx

@W0ngL1
Copy link
Contributor Author

W0ngL1 commented Oct 2, 2025

Hi @tooryx,

No problem, I'll update the new binproto file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRP: Request Web Application Fingerprint - Grafana
3 participants