Skip to content

Conversation

JamesFoxxx
Copy link
Contributor

@JamesFoxxx JamesFoxxx commented Aug 1, 2025

@giacomo-doyensec
Copy link
Collaborator

Hi @JamesFoxxx, thanks for your contribution!
I’m running into some issues with the detector. If the callback server returns a 404 or is unavailable, the workflow fails and skips the cleanup phase. Similarly, if the job already exists, the detector fails and again skips cleanup.

Could you update the implementation to handle these edge cases properly? Ideally, the job should use a random name (to avoid clashes with existing ones), and a cleanup action should be added to trigger_code_execution . Thanks!

@JamesFoxxx
Copy link
Contributor Author

About the random string, I think we need to borrow a random string from the target server itself(like the csrftoken) and append it to the job name, or we can use a constant job name and ignore the matching of job cleanup action response status code and run this action after the fingerprint action( it will be rerun as a cleanup action again). The reason for ignoring the response status code is that if the job with a constant name doesn't exist, it returns 404; if the job is created and exists, then it returns 200.

…sses some cases we didn't clean the job with cleanup_actions
@JamesFoxxx
Copy link
Contributor Author

@giacomo-doyensec I implemented an additional job to clean up after the fingerprint action for demonstration.

@giacomo-doyensec
Copy link
Collaborator

giacomo-doyensec commented Oct 2, 2025

LGTM - Approved
@tooryx we can merge this and google/security-testbeds#146

Reviewer: Giacomo, Doyensec
Plugin: Exposed K8s Dashboard

@copybara-service copybara-service bot merged commit 849bf5c into google:master Oct 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRP: exposed K8s dashboard
3 participants