feat: upload textproto for Ofbiz_CVE_2023_51467 #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tooryx, @leonardo-doyensec,
It's the templated plugin for Ofbiz_CVE_2023_51467, whick linked to #388.
Here is the testbed PR: google/security-testbeds#168.
I found a small but practical issue when testing Apache OFBiz: after deployment OFBiz treats localhost as a trusted host by default, so requests that use any other IP trigger a “host not trusted” error. To work around this I added a Host: localhost header in my vulnerability plugin requests, but in real scans the trusted host can get changed by the configuration, which makes reliable reproduction harder.
I considered using the built-in T_NS_HOSTNAME variable, but that doesn’t match the local deployment behavior I want to reproduce (it’s inconvenient to force a scanner to use the machine’s hostname as Host).
A few ideas that might help:
Add an explicit option to the scanner/plugin to force a custom Host header (e.g. force_host: "localhost") so tests can reliably reproduce host-based checks even when proxying or using different target IPs.