Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Jan 6, 2026

We're keeping a few things back:

We're keeping a few things back:
- serialport to 4.7.3 because of serialport/serialport-rs#304
- rust toolchain to 2025-11-07 because rust-lang/rust#149488 does not have rustfmt support yet
@ia0 ia0 added the for:maintainability Improves maintainers life label Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily updates numerous Rust dependencies across various crates, including core libraries like proc-macro2, quote, syn, clap, log, reqwest, toml, and wasmtime, along with several new additions and removals in Cargo.lock files. However, the review comments indicate a critical issue where multiple Cargo.lock files incorrectly reference a non-existent version of the thiserror crate (2.0.17 instead of 1.0.69), suggesting a corrupted lock file that could cause build failures. The reviewer recommends regenerating these files.

@ia0 ia0 merged commit 7f82e92 into google:main Jan 6, 2026
27 checks passed
@ia0 ia0 deleted the upgrade branch January 6, 2026 12:15
@ia0
Copy link
Member Author

ia0 commented Jan 6, 2026

HWCI for Nordic and OpenTitan passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:maintainability Improves maintainers life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants