Skip to content

Conversation

@lindsey-volta
Copy link
Contributor

@lindsey-volta lindsey-volta commented Sep 29, 2025

Address a number of linting issues, mainly of type @typescript-eslint/no-unused-vars.

For two instances setVariant and setCheckoutState (part of the Enhanced Ecommerce demo), the warning is occurring because the functionality is partially implemented. The features need to be revisited and implementation needs to be reevaluated more thoroughly. For now, this PR:

  • Adds an // eslint-disable-next-line @typescript-eslint/no-unused-vars comment for each unused setter.
  • Adds a // TODO: comment to each, explaining why the linter rule is being disabled and clarifying what feature needs to be implemented.

This will clean up the lint output (which has been flagging each PR) while preserving the existing code and context for future development.

@lindsey-volta
Copy link
Contributor Author

The remaining warning for setGAVersion will be resolved as part of the cleanup/refactoring done in #2248 once it's merged

@lindsey-volta lindsey-volta marked this pull request as ready for review September 29, 2025 20:39
Copy link
Member

@jradcliff jradcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lindsey-volta lindsey-volta merged commit 1da0cb2 into main Sep 29, 2025
7 checks passed
@lindsey-volta lindsey-volta deleted the resolve-warnings branch September 29, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants