Skip to content

docs: update urllib3 docstrings for v2 compatibility #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: update urllib3 docstrings for v2 compatibility #1903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions google/auth/transport/urllib3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,8 @@ class Request(transport.Request):
credentials.refresh(request)

Args:
http (urllib3.request.RequestMethods): An instance of any urllib3
class that implements :class:`~urllib3.request.RequestMethods`,
usually :class:`urllib3.PoolManager`.
http (urllib3.PoolManager): An instance of a urllib3 class that implements
the request interface (e.g. :class:`urllib3.PoolManager`).

.. automethod:: __call__
"""
Expand Down Expand Up @@ -209,7 +208,7 @@ class AuthorizedHttp(RequestMethods): # type: ignore
response = authed_http.request(
'GET', 'https://www.googleapis.com/storage/v1/b')

This class implements :class:`urllib3.request.RequestMethods` and can be
This class implements the urllib3 request interface and can be
used just like any other :class:`urllib3.PoolManager`.

The underlying :meth:`urlopen` implementation handles adding the
Expand Down
Loading