chore(v3): remove no-private-header flag

[scotthart]

This flag wasn't always recognized. We'll look at other solutions if header warnings are an issue.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Bazel build configuration by eliminating an ineffective -Wno-private-header flag. The change addresses a known issue where the flag was not consistently recognized, aiming to streamline the build process. The team plans to investigate other methods for managing header warnings should they arise in the future.

Highlights

• Configuration Simplification: The -Wno-private-header flag has been removed from the .bazelrc configuration file.
• Flag Recognition Issue: This flag was removed because it was not consistently recognized by the build system.
• Future Warning Management: Alternative solutions will be explored if header warnings become an issue after this change.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes several build flags related to -Wno-private-header from the root .bazelrc file. This change is part of the preparation for v3.0.0. As noted in the pull request description, this flag was not always recognized, so its removal is a sensible cleanup of the build configuration. The change is simple and correct. I have verified that this flag is not used in other build configurations in the repository. This is a good housekeeping change.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (344198f) to head (39491a5).
⚠️ Report is 4 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15863      +/-   ##
======================================================
- Coverage               92.84%   92.84%   -0.01%     
======================================================
  Files                    2419     2419              
  Lines                  222736   222736              
======================================================
- Hits                   206807   206804       -3     
- Misses                  15929    15932       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.