Skip to content

fix(auth): remove content-type header from idms get requests #9508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyoss merged 2 commits into from
Mar 12, 2024
Merged

fix(auth): remove content-type header from idms get requests #9508

codyoss merged 2 commits into from
Mar 12, 2024

Conversation

@peter-volkov
Copy link
Contributor

@peter-volkov peter-volkov commented Mar 5, 2024

@peter-volkov peter-volkov requested a review from a team as a code owner March 5, 2024 12:56
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 5, 2024
@codyoss
Copy link
Member

codyoss commented Mar 5, 2024

Hey thanks for the detailed report and PR. I have forwarded the bug to our internal auth team. If this is a change we should make we likely need to make it in all the languages we support. So until they make a decision I will hold off on this PR.

@peter-volkov
Copy link
Contributor Author

peter-volkov commented Mar 5, 2024 •
edited
Loading

Thanks. I already sent a similar PR to the python SDK
googleapis/google-auth-library-python#1489

@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 5, 2024
@parthea parthea mentioned this pull request Mar 5, 2024
Open
@BigTailWolf BigTailWolf mentioned this pull request Mar 11, 2024
Closed
@BigTailWolf
Copy link

BigTailWolf commented Mar 11, 2024

Hi @codyoss , i made a similar fix in the dependency source which doesn't have this conflict. golang/oauth2#711

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2024
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Mar 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2024
@codyoss
Copy link
Member

codyoss commented Mar 12, 2024

@peter-volkov Thank you for raising this to our attention. We will be moving forward with this patch.

gopherbot pushed a commit to golang/oauth2 that referenced this pull request Mar 12, 2024
@BigTailWolf @codyoss
oauth2/google: fix remove content-type header from idms get requests
5a05c65 
This is a fix on the googleapis/google-cloud-go#9508.
The aws provider in that library is a ported dependency from here.

Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88
GitHub-Last-Rev: c425f2d
GitHub-Pull-Request: #711
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875
Reviewed-by: Cody Oss <codyoss@google.com>
Reviewed-by: Chris Smith <chrisdsmith@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Mar 12, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 12, 2024
@codyoss codyoss changed the title fix: remove content-type header from idms get requests fix(auth): remove content-type header from idms get requests Mar 12, 2024
@codyoss codyoss merged commit 8589f41 into googleapis:main Mar 12, 2024
@release-please release-please bot mentioned this pull request Mar 12, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 15, 2024
@release-please
chore(main): release auth 0.2.0 (#9559)
d486481 
🤖 I have created a release *beep* *boop*
---


## [0.2.0](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.1.1...auth/v0.2.0) (2024-04-15)


### Features

* **auth/credentials/externalaccount:** Add default TokenURL ([#9700](https://togithub.com/googleapis/google-cloud-go/issues/9700)) ([81830e6](https://togithub.com/googleapis/google-cloud-go/commit/81830e6848ceefd055aa4d08f933d1154455a0f6))
* **auth:** Add downscope.Options.UniverseDomain ([#9634](https://togithub.com/googleapis/google-cloud-go/issues/9634)) ([52cf7d7](https://togithub.com/googleapis/google-cloud-go/commit/52cf7d780853594291c4e34302d618299d1f5a1d))
* **auth:** Add universe domain to grpctransport and httptransport ([#9663](https://togithub.com/googleapis/google-cloud-go/issues/9663)) ([67d353b](https://togithub.com/googleapis/google-cloud-go/commit/67d353beefe3b607c08c891876fbd95ab89e5fe3)), refs [#9670](https://togithub.com/googleapis/google-cloud-go/issues/9670)
* **auth:** Add UniverseDomain to DetectOptions ([#9536](https://togithub.com/googleapis/google-cloud-go/issues/9536)) ([3618d3f](https://togithub.com/googleapis/google-cloud-go/commit/3618d3f7061615c0e189f376c75abc201203b501))
* **auth:** Make package externalaccount public ([#9633](https://togithub.com/googleapis/google-cloud-go/issues/9633)) ([a0978d8](https://togithub.com/googleapis/google-cloud-go/commit/a0978d8e96968399940ebd7d092539772bf9caac))
* **auth:** Move credentials to base auth package ([#9590](https://togithub.com/googleapis/google-cloud-go/issues/9590)) ([1a04baf](https://togithub.com/googleapis/google-cloud-go/commit/1a04bafa83c27342b9308d785645e1e5423ea10d))
* **auth:** Refactor public sigs to use Credentials ([#9603](https://togithub.com/googleapis/google-cloud-go/issues/9603)) ([69cb240](https://togithub.com/googleapis/google-cloud-go/commit/69cb240c530b1f7173a9af2555c19e9a1beb56c5))


### Bug Fixes

* **auth/oauth2adapt:** Update protobuf dep to v1.33.0 ([30b038d](https://togithub.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a))
* **auth:** Fix uint32 conversion ([9221c7f](https://togithub.com/googleapis/google-cloud-go/commit/9221c7fa12cef9d5fb7ddc92f41f1d6204971c7b))
* **auth:** Port sts expires fix ([#9618](https://togithub.com/googleapis/google-cloud-go/issues/9618)) ([7bec97b](https://togithub.com/googleapis/google-cloud-go/commit/7bec97b2f51ed3ac4f9b88bf100d301da3f5d1bd))
* **auth:** Read universe_domain from all credentials files ([#9632](https://togithub.com/googleapis/google-cloud-go/issues/9632)) ([16efbb5](https://togithub.com/googleapis/google-cloud-go/commit/16efbb52e39ea4a319e5ee1e95c0e0305b6d9824))
* **auth:** Remove content-type header from idms get requests ([#9508](https://togithub.com/googleapis/google-cloud-go/issues/9508)) ([8589f41](https://togithub.com/googleapis/google-cloud-go/commit/8589f41599d265d7c3d46a3d86c9fab2329cbdd9))
* **auth:** Update protobuf dep to v1.33.0 ([30b038d](https://togithub.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
jbrichetto pushed a commit to openly-engineering/oauth2 that referenced this pull request May 22, 2024
@BigTailWolf @jbrichetto
oauth2/google: fix remove content-type header from idms get requests
cb3c6b4 
This is a fix on the googleapis/google-cloud-go#9508.
The aws provider in that library is a ported dependency from here.

Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88
GitHub-Last-Rev: c425f2d
GitHub-Pull-Request: golang#711
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875
Reviewed-by: Cody Oss <codyoss@google.com>
Reviewed-by: Chris Smith <chrisdsmith@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peter-volkov @codyoss @BigTailWolf @kokoro-team