-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian release pull request: 20251217T215457Z #14978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release preparation generated by the Librarian CLI. Its primary purpose is to update the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google-cloud-secret-manager library to version 2.26.0 across multiple files, including .librarian/state.yaml, the main CHANGELOG.md, and various gapic_version.py files within the package. The update to the package's CHANGELOG.md introduces features such as auto-enabling mTLS and checking Python/dependency versions in generated GAPICs. A review comment noted an inconsistency in the top-level CHANGELOG.md, where the previous version was incorrectly listed as 2.24.0 instead of 2.25.0, although the PR correctly updates it to 2.26.0.
| - [google-cloud-saasplatform-saasservicemgmt==0.2.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-saasplatform-saasservicemgmt/CHANGELOG.md) | ||
| - [google-cloud-scheduler==2.17.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-scheduler/CHANGELOG.md) | ||
| - [google-cloud-secret-manager==2.24.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-secret-manager/CHANGELOG.md) | ||
| - [google-cloud-secret-manager==2.26.0](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-secret-manager/CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version listed here was 2.24.0, but other parts of this PR (like the PR description and .librarian/state.yaml) indicate the previous version was 2.25.0. This top-level CHANGELOG.md seems to have been out of sync. While this PR correctly updates it to 2.26.0, the base version was incorrect.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.0.0-20251113212345-55e52e492404
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
google-cloud-secret-manager: 2.26.0
2.26.0 (2025-12-17)
Features
check Python and dependency versions in generated GAPICs (PiperOrigin-RevId: 845448683) (d2b35b25)
auto-enable mTLS when supported certificates are detected (PiperOrigin-RevId: 845448683) (d2b35b25)