Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 22, 2025

Part of the work for #3941

Add a builder for a streaming pull bidi RPC. This class will eventually be public, and thus it must have documentation.

For now, this thing just sets options. It will gain a fn start(self) -> Result<Session> later, when Session is a thing.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (ddd9cb9) to head (639d81b).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4118      +/-   ##
==========================================
- Coverage   94.84%   94.82%   -0.03%     
==========================================
  Files         181      182       +1     
  Lines        6853     6864      +11     
==========================================
+ Hits         6500     6509       +9     
- Misses        353      355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review December 22, 2025 23:44
@dbolduc dbolduc requested a review from a team as a code owner December 22, 2025 23:44
suzmue
suzmue previously approved these changes Dec 23, 2025
Copy link
Member Author

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@dbolduc dbolduc merged commit cb1255b into googleapis:main Dec 29, 2025
29 checks passed
@dbolduc dbolduc deleted the impl-pubsub-streaming-pull-builder branch December 29, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants