-
Notifications
You must be signed in to change notification settings - Fork 87
feat: adding Otel for MPU #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dhriti07
wants to merge
7
commits into
main
Choose a base branch
from
mpu-otel-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+349
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed6998a to
df66376
Compare
BenWhitehead
requested changes
Nov 20, 2025
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint failures can be fixed by running
JAVA_HOME=$JAVA_17_HOME mvn com.spotify.fmt:fmt-maven-plugin:format
This branch will need to be rebased on main to pickup the new method for listing uploads. git fetch --all && git rebase -i origin/main
Other than that, this is looking like I'd expect it to.
...cloud-storage/src/main/java/com/google/cloud/storage/OtelMultipartUploadClientDecorator.java
Outdated
Show resolved
Hide resolved
BenWhitehead
previously approved these changes
Dec 10, 2025
ShreyasSinha
requested changes
Dec 17, 2025
...cloud-storage/src/main/java/com/google/cloud/storage/OtelMultipartUploadClientDecorator.java
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/ITOpenTelemetryMPUTest.java
Outdated
Show resolved
Hide resolved
7427a60 to
c785fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.