Skip to content

fix: GenAI SDK client - Fix log showing how to get an Agent Engine. Positional arguments are not allowed. #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 22, 2025
Merged

fix: GenAI SDK client - Fix log showing how to get an Agent Engine. Positional arguments are not allowed. #5952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/vertexai/genai/test_agent_engines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ def test_create_agent_engine(self, mock_await_operation, mock_prepare, caplog):
assert "View progress and logs at" in caplog.text
assert "Agent Engine created. To use it in another session:" in caplog.text
assert (
f"agent_engine=client.agent_engines.get("
f"agent_engine=client.agent_engines.get(name="
f"'{_TEST_AGENT_ENGINE_RESOURCE_NAME}')" in caplog.text
)

Expand Down Expand Up @@ -1687,7 +1687,7 @@ def test_update_agent_engine_requirements(
assert "Agent Engine updated. To use it in another session:" in caplog.text
assert (
f"agent_engine=client.agent_engines.get("
f"'{_TEST_AGENT_ENGINE_RESOURCE_NAME}')" in caplog.text
f"name='{_TEST_AGENT_ENGINE_RESOURCE_NAME}')" in caplog.text
)

@mock.patch.object(_agent_engines_utils, "_prepare")
Expand Down
4 changes: 2 additions & 2 deletions vertexai/_genai/agent_engines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ def create(
if agent_engine.api_resource:
logger.info("Agent Engine created. To use it in another session:")
logger.info(
f"agent_engine=client.agent_engines.get('{agent_engine.api_resource.name}')"
f"agent_engine=client.agent_engines.get(name='{agent_engine.api_resource.name}')"
)
elif operation.error:
raise RuntimeError(f"Failed to create Agent Engine: {operation.error}")
Expand Down Expand Up @@ -1313,7 +1313,7 @@ def update(
if agent_engine.api_resource:
logger.info("Agent Engine updated. To use it in another session:")
logger.info(
f"agent_engine=client.agent_engines.get('{agent_engine.api_resource.name}')"
f"agent_engine=client.agent_engines.get(name='{agent_engine.api_resource.name}')"
)
elif operation.error:
raise RuntimeError(f"Failed to update Agent Engine: {operation.error}")
Expand Down
Loading