Skip to content

fix: GenAI Client(evals) - Remove requirement for agent_info.agent in create_evaluation_run in Vertex AI GenAI SDK evals. #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 4, 2025
Merged

fix: GenAI Client(evals) - Remove requirement for agent_info.agent in create_evaluation_run in Vertex AI GenAI SDK evals. #6082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 10 additions & 26 deletions vertexai/_genai/evals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,15 +1397,6 @@ def create_evaluation_run(
)
inference_configs = {}
if agent_info:
if isinstance(agent_info, dict):
agent_info = types.evals.AgentInfo.model_validate(agent_info)
if (
not agent_info.agent
or len(agent_info.agent.split("reasoningEngines/")) != 2
):
raise ValueError(
"agent_info.agent cannot be empty. Please provide a valid reasoning engine resource name in the format of projects/{project}/locations/{location}/reasoningEngines/{reasoning_engine}."
)
inference_configs[agent_info.name] = types.EvaluationRunInferenceConfig(
agent_config=types.EvaluationRunAgentConfig(
developer_instruction=genai_types.Content(
Expand All @@ -1414,10 +1405,11 @@ def create_evaluation_run(
tools=agent_info.tool_declarations,
)
)
labels = labels or {}
labels["vertex-ai-evaluation-agent-engine-id"] = agent_info.agent.split(
"reasoningEngines/"
)[-1]
if agent_info.agent:
labels = labels or {}
labels["vertex-ai-evaluation-agent-engine-id"] = agent_info.agent.split(
"reasoningEngines/"
)[-1]
if not name:
name = f"evaluation_run_{uuid.uuid4()}"

Expand Down Expand Up @@ -2252,15 +2244,6 @@ async def create_evaluation_run(
)
inference_configs = {}
if agent_info:
if isinstance(agent_info, dict):
agent_info = types.evals.AgentInfo.model_validate(agent_info)
if (
not agent_info.agent
or len(agent_info.agent.split("reasoningEngines/")) != 2
):
raise ValueError(
"agent_info.agent cannot be empty. Please provide a valid reasoning engine resource name in the format of projects/{project}/locations/{location}/reasoningEngines/{reasoning_engine}."
)
inference_configs[agent_info.name] = types.EvaluationRunInferenceConfig(
agent_config=types.EvaluationRunAgentConfig(
developer_instruction=genai_types.Content(
Expand All @@ -2269,10 +2252,11 @@ async def create_evaluation_run(
tools=agent_info.tool_declarations,
)
)
labels = labels or {}
labels["vertex-ai-evaluation-agent-engine-id"] = agent_info.agent.split(
"reasoningEngines/"
)[-1]
if agent_info.agent:
labels = labels or {}
labels["vertex-ai-evaluation-agent-engine-id"] = agent_info.agent.split(
"reasoningEngines/"
)[-1]
if not name:
name = f"evaluation_run_{uuid.uuid4()}"

Expand Down
Loading