Skip to content

fix: use _init_session for in_memory session case #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
copybara-service wants to merge 1 commit into from
Closed

fix: use _init_session for in_memory session case #6083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vertexai/agent_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,10 +1095,10 @@ async def streaming_agent_run_with_events(self, request_json: str):
session_service = self._tmpl_attrs.get("in_memory_session_service")
artifact_service = self._tmpl_attrs.get("in_memory_artifact_service")
runner = self._tmpl_attrs.get("in_memory_runner")
session = await session_service.create_session(
app_name=self._tmpl_attrs.get("app_name"),
user_id=request.user_id,
session_id=request.session_id,
session = await self._init_session(
session_service=session_service,
artifact_service=artifact_service,
request=request,
)
if not session:
raise RuntimeError("Session initialization failed.")
Expand Down
8 changes: 4 additions & 4 deletions vertexai/preview/reasoning_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,10 +982,10 @@ async def _invoke_agent_async():
session_service = self._tmpl_attrs.get("in_memory_session_service")
artifact_service = self._tmpl_attrs.get("in_memory_artifact_service")
runner = self._tmpl_attrs.get("in_memory_runner")
session = await session_service.create_session(
app_name=self._tmpl_attrs.get("app_name"),
user_id=request.user_id,
session_id=request.session_id,
session = await self._init_session(
session_service=session_service,
artifact_service=artifact_service,
request=request,
)
if not session:
raise RuntimeError("Session initialization failed.")
Expand Down