Skip to content

chore: GenAI SDK client - fix mypy errors in datasets module #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 17, 2025
Merged

chore: GenAI SDK client - fix mypy errors in datasets module #6128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions vertexai/_genai/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,8 @@ def _wait_for_operation(
ValueError: If the operation fails.
"""
response_operation_name = operation.name
if response_operation_name is None:
raise ValueError("Dataset operation name is empty.")
dataset_id = response_operation_name.split("/datasets/")[1].split("/")[0]
operation_id = response_operation_name.split("/")[-1]

Expand Down Expand Up @@ -662,6 +664,30 @@ def create_from_bigquery(
"""
if isinstance(multimodal_dataset, dict):
multimodal_dataset = types.MultimodalDataset(**multimodal_dataset)
if (
not hasattr(multimodal_dataset, "metadata")
or multimodal_dataset.metadata is None
):
raise ValueError("Multimodal dataset metadata is required.")
if (
not hasattr(multimodal_dataset.metadata, "input_config")
or multimodal_dataset.metadata.input_config is None
):
raise ValueError("Multimodal dataset input config is required.")
if (
not hasattr(multimodal_dataset.metadata.input_config, "bigquery_source")
or multimodal_dataset.metadata.input_config.bigquery_source is None
):
raise ValueError(
"Multimodal dataset input config bigquery source is required."
)
if (
not hasattr(multimodal_dataset.metadata.input_config.bigquery_source, "uri")
or multimodal_dataset.metadata.input_config.bigquery_source.uri is None
):
raise ValueError(
"Multimodal dataset input config bigquery source uri is required."
)
if not multimodal_dataset.metadata.input_config.bigquery_source.uri.startswith(
"bq://"
):
Expand Down Expand Up @@ -710,6 +736,30 @@ def update_multimodal_dataset(
"""
if isinstance(multimodal_dataset, dict):
multimodal_dataset = types.MultimodalDataset(**multimodal_dataset)
if (
not hasattr(multimodal_dataset, "metadata")
or multimodal_dataset.metadata is None
):
raise ValueError("Multimodal dataset metadata is required.")
if (
not hasattr(multimodal_dataset.metadata, "input_config")
or multimodal_dataset.metadata.input_config is None
):
raise ValueError("Multimodal dataset input config is required.")
if (
not hasattr(multimodal_dataset.metadata.input_config, "bigquery_source")
or multimodal_dataset.metadata.input_config.bigquery_source is None
):
raise ValueError(
"Multimodal dataset input config bigquery source is required."
)
if (
not hasattr(multimodal_dataset.metadata.input_config.bigquery_source, "uri")
or multimodal_dataset.metadata.input_config.bigquery_source.uri is None
):
raise ValueError(
"Multimodal dataset input config bigquery source uri is required."
)
if not multimodal_dataset.metadata.input_config.bigquery_source.uri.startswith(
"bq://"
):
Expand Down Expand Up @@ -1258,6 +1308,8 @@ async def _wait_for_operation(
ValueError: If the operation fails.
"""
response_operation_name = operation.name
if response_operation_name is None:
raise ValueError("Dataset operation name is empty.")
dataset_id = response_operation_name.split("/datasets/")[1].split("/")[0]
operation_id = response_operation_name.split("/")[-1]

Expand Down Expand Up @@ -1309,6 +1361,30 @@ async def create_from_bigquery(
"""
if isinstance(multimodal_dataset, dict):
multimodal_dataset = types.MultimodalDataset(**multimodal_dataset)
if (
not hasattr(multimodal_dataset, "metadata")
or multimodal_dataset.metadata is None
):
raise ValueError("Multimodal dataset metadata is required.")
if (
not hasattr(multimodal_dataset.metadata, "input_config")
or multimodal_dataset.metadata.input_config is None
):
raise ValueError("Multimodal dataset input config is required.")
if (
not hasattr(multimodal_dataset.metadata.input_config, "bigquery_source")
or multimodal_dataset.metadata.input_config.bigquery_source is None
):
raise ValueError(
"Multimodal dataset input config bigquery source is required."
)
if (
not hasattr(multimodal_dataset.metadata.input_config.bigquery_source, "uri")
or multimodal_dataset.metadata.input_config.bigquery_source.uri is None
):
raise ValueError(
"Multimodal dataset input config bigquery source uri is required."
)
if not multimodal_dataset.metadata.input_config.bigquery_source.uri.startswith(
"bq://"
):
Expand Down Expand Up @@ -1353,6 +1429,30 @@ async def update_multimodal_dataset(
"""
if isinstance(multimodal_dataset, dict):
multimodal_dataset = types.MultimodalDataset(**multimodal_dataset)
if (
not hasattr(multimodal_dataset, "metadata")
or multimodal_dataset.metadata is None
):
raise ValueError("Multimodal dataset metadata is required.")
if (
not hasattr(multimodal_dataset.metadata, "input_config")
or multimodal_dataset.metadata.input_config is None
):
raise ValueError("Multimodal dataset input config is required.")
if (
not hasattr(multimodal_dataset.metadata.input_config, "bigquery_source")
or multimodal_dataset.metadata.input_config.bigquery_source is None
):
raise ValueError(
"Multimodal dataset input config bigquery source is required."
)
if (
not hasattr(multimodal_dataset.metadata.input_config.bigquery_source, "uri")
or multimodal_dataset.metadata.input_config.bigquery_source.uri is None
):
raise ValueError(
"Multimodal dataset input config bigquery source uri is required."
)
if not multimodal_dataset.metadata.input_config.bigquery_source.uri.startswith(
"bq://"
):
Expand Down
Loading