Skip to content

fix: GenAI SDK client(eval) - Reorder the params to put the Config param at the last place. #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Nov 21, 2025
Merged

fix: GenAI SDK client(eval) - Reorder the params to put the Config param at the last place. #6160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions vertexai/_genai/evals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ def _CreateEvaluationRunParameters_to_vertex(
if getv(from_object, ["labels"]) is not None:
setv(to_object, ["labels"], getv(from_object, ["labels"]))

if getv(from_object, ["config"]) is not None:
setv(to_object, ["config"], getv(from_object, ["config"]))

if getv(from_object, ["inference_configs"]) is not None:
setv(to_object, ["inferenceConfigs"], getv(from_object, ["inference_configs"]))

if getv(from_object, ["config"]) is not None:
setv(to_object, ["config"], getv(from_object, ["config"]))

return to_object


Expand Down Expand Up @@ -472,10 +472,10 @@ def _create_evaluation_run(
data_source: types.EvaluationRunDataSourceOrDict,
evaluation_config: types.EvaluationRunConfigOrDict,
labels: Optional[dict[str, str]] = None,
config: Optional[types.CreateEvaluationRunConfigOrDict] = None,
inference_configs: Optional[
dict[str, types.EvaluationRunInferenceConfigOrDict]
] = None,
config: Optional[types.CreateEvaluationRunConfigOrDict] = None,
) -> types.EvaluationRun:
"""
Creates an EvaluationRun.
Expand All @@ -487,8 +487,8 @@ def _create_evaluation_run(
data_source=data_source,
evaluation_config=evaluation_config,
labels=labels,
config=config,
inference_configs=inference_configs,
config=config,
)

request_url_dict: Optional[dict[str, str]]
Expand Down Expand Up @@ -1627,10 +1627,10 @@ async def _create_evaluation_run(
data_source: types.EvaluationRunDataSourceOrDict,
evaluation_config: types.EvaluationRunConfigOrDict,
labels: Optional[dict[str, str]] = None,
config: Optional[types.CreateEvaluationRunConfigOrDict] = None,
inference_configs: Optional[
dict[str, types.EvaluationRunInferenceConfigOrDict]
] = None,
config: Optional[types.CreateEvaluationRunConfigOrDict] = None,
) -> types.EvaluationRun:
"""
Creates an EvaluationRun.
Expand All @@ -1642,8 +1642,8 @@ async def _create_evaluation_run(
data_source=data_source,
evaluation_config=evaluation_config,
labels=labels,
config=config,
inference_configs=inference_configs,
config=config,
)

request_url_dict: Optional[dict[str, str]]
Expand Down
8 changes: 4 additions & 4 deletions vertexai/_genai/types/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,10 +1034,10 @@ class _CreateEvaluationRunParameters(_common.BaseModel):
default=None, description=""""""
)
labels: Optional[dict[str, str]] = Field(default=None, description="""""")
config: Optional[CreateEvaluationRunConfig] = Field(
inference_configs: Optional[dict[str, "EvaluationRunInferenceConfig"]] = Field(
default=None, description=""""""
)
inference_configs: Optional[dict[str, "EvaluationRunInferenceConfig"]] = Field(
config: Optional[CreateEvaluationRunConfig] = Field(
default=None, description=""""""
)

Expand All @@ -1060,10 +1060,10 @@ class _CreateEvaluationRunParametersDict(TypedDict, total=False):
labels: Optional[dict[str, str]]
""""""

config: Optional[CreateEvaluationRunConfigDict]
inference_configs: Optional[dict[str, "EvaluationRunInferenceConfigDict"]]
""""""

inference_configs: Optional[dict[str, "EvaluationRunInferenceConfigDict"]]
config: Optional[CreateEvaluationRunConfigDict]
""""""


Expand Down
Loading