chore: librarian update image pull request: 20251215T152650Z

[daniel-sanche]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8b2565040b8f040cbdad8eb4f861a7f2156c6a87965c7baa2d942eb16a57ff19

Generation failed for

• google-cloud-firestore

[daniel-sanche]

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

[gemini-code-assist]

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the Librarian image used for code generation. A significant consequence of this update is the complete removal of the google-cloud-firestore client library and its associated modules from the repository. This action, indicated by the PR body's note about 'Generation failed for - google-cloud-firestore,' suggests a re-evaluation or change in the generation strategy for this specific library, possibly leading to its relocation or a different maintenance approach. The PR also includes a comprehensive cleanup of various project-level configuration and documentation files that are no longer relevant after the library's removal.

Highlights

• Librarian Image Update: The core code generation image used by Librarian has been updated to a new version, identified by a new SHA256 hash.
• Google Cloud Firestore Library Removal: The entire google-cloud-firestore client library, including its administrative (firestore_admin_v1) and bundle (firestore_bundle) components, has been removed from the repository. This action follows previous generation failures for this library.
• Configuration and Documentation Cleanup: Various project configuration files (e.g., .pre-commit-config.yaml, .repo-metadata.json, .trampolinerc) and documentation files (README.rst, docs/README.rst, SECURITY.md, docs/summary_overview.md) associated with the removed library have been deleted.
• Coverage Configuration Adjustment: The .coveragerc file was updated to remove previous general exclusions and add new specific omissions for firestore_admin components, reflecting the library's removal.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be the result of a failed generator run. It removes a vast number of critical source code and project files, effectively deleting the google-cloud-firestore library. The PR description itself notes that the generation failed. This is a critical issue, and this pull request must not be merged. The underlying generator failure needs to be investigated and fixed.

I am having trouble creating individual review comments. Click here to see my feedback.

.coveragerc (25)

Removing the fail_under = 100 configuration for code coverage is a significant regression in code quality standards. This change, along with the mass deletion of files throughout the repository, indicates a severe problem with this automated pull request. It should not be merged.

.pre-commit-config.yaml (1-31)

This file, which configures essential pre-commit hooks for maintaining code quality (e.g., black, flake8), is being deleted. This, along with the removal of many other project configuration and source files, indicates a catastrophic failure in the generation process. This PR should be rejected.

README.rst (1-197)

This pull request deletes the main README.rst file for the project, along with many other critical project files like .repo-metadata.json and SECURITY.md. This is indicative of a catastrophic failure in the generation process and will break the repository.

google/cloud/firestore_v1/services/firestore/async_client.py (1-2206)

This change removes the FirestoreAsyncClient, which is a core part of the library's public API. The deletion of this and many other source files renders the library unusable. This PR seems to be the result of a failed generation and should be reverted.