Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

Autogenerated gapic update

Includes:

  • support for mTLS by default when the environment detects it
  • support for pipelines protos

@daniel-sanche daniel-sanche requested review from a team as code owners December 16, 2025 01:03
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 16, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 16, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a significant update to the Firestore GAPIC client, primarily driven by an autogenerated refresh. The core enhancements include robust support for mTLS, enabling more secure client-server authentication, and the introduction of a new query execution model via 'pipelines protos'. These changes expand the client's capabilities for complex data operations and improve its security posture, ensuring it remains aligned with the latest service features and best practices.

Highlights

  • mTLS Support: The client now automatically supports mTLS (mutual TLS) certificates when the environment detects their availability. This enhances secure communication by introducing a new static method _use_client_cert_effective() to determine mTLS usage, which is then integrated into the client's endpoint and certificate source logic.
  • Pipelines Protos Integration: New functionality has been added to support 'pipelines protos', which introduces a structured way to define and execute queries. This includes new proto messages for Function, Pipeline, StructuredPipeline, and ExplainStats, along with corresponding client methods (execute_pipeline) and transport implementations across gRPC and REST.
  • Autogenerated Update: The majority of the changes are autogenerated, indicated by an update to the python-librarian-generator image version in .librarian/state.yaml and the addition of a specific 'DO NOT EDIT' comment in numerous Python files, signifying an update to the underlying GAPIC client generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an autogenerated GAPIC update that introduces mTLS support and a new execute_pipeline feature. The mTLS implementation refactors existing logic into a _use_client_cert_effective method, which is a good improvement for maintainability. The new execute_pipeline feature, however, contains incorrect sample code in its docstrings. My review includes suggestions to fix the sample code to ensure it is functional for users. The rest of the changes appear to be standard for an autogenerated update and look correct.

@daniel-sanche daniel-sanche merged commit 403afb0 into main Dec 16, 2025
24 of 25 checks passed
@daniel-sanche daniel-sanche deleted the update_gapic branch December 16, 2025 16:51
daniel-sanche added a commit that referenced this pull request Dec 17, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-firestore: 2.22.0</summary>

##
[2.22.0](v2.21.0...v2.22.0)
(2025-12-16)

### Features

* support mTLS certificates when available (#1140)
([403afb0](403afb08))

* Expose tags field in Database and RestoreDatabaseRequest public protos
(#1074)
([4983639](49836391))

* Add support for Python 3.14 (#1110)
([52b2055](52b2055d))

* Added read_time as a parameter to various calls (synchronous/base
classes) (#1050)
([d8e3af1](d8e3af1f))

### Bug Fixes

* update the async transactional types (#1066)
([210a14a](210a14a4))

* improve typing (#1136)
([d1c730d](d1c730d9))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants