-
Notifications
You must be signed in to change notification settings - Fork 83
feat(gapic): support mTLS certificates when available #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant update to the Firestore GAPIC client, primarily driven by an autogenerated refresh. The core enhancements include robust support for mTLS, enabling more secure client-server authentication, and the introduction of a new query execution model via 'pipelines protos'. These changes expand the client's capabilities for complex data operations and improve its security posture, ensuring it remains aligned with the latest service features and best practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an autogenerated GAPIC update that introduces mTLS support and a new execute_pipeline feature. The mTLS implementation refactors existing logic into a _use_client_cert_effective method, which is a good improvement for maintainability. The new execute_pipeline feature, however, contains incorrect sample code in its docstrings. My review includes suggestions to fix the sample code to ensure it is functional for users. The rest of the changes appear to be standard for an autogenerated update and look correct.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-cloud-firestore: 2.22.0</summary> ## [2.22.0](v2.21.0...v2.22.0) (2025-12-16) ### Features * support mTLS certificates when available (#1140) ([403afb0](403afb08)) * Expose tags field in Database and RestoreDatabaseRequest public protos (#1074) ([4983639](49836391)) * Add support for Python 3.14 (#1110) ([52b2055](52b2055d)) * Added read_time as a parameter to various calls (synchronous/base classes) (#1050) ([d8e3af1](d8e3af1f)) ### Bug Fixes * update the async transactional types (#1066) ([210a14a](210a14a4)) * improve typing (#1136) ([d1c730d](d1c730d9)) </details>
Autogenerated gapic update
Includes: