chore: librarian update image pull request: 20251215T171928Z

[daniel-sanche]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:eec191fc4904c204cd717c79812cd66997b5559776483ee223f69c8f43e99224

Generation failed for

• google-cloud-firestore

[daniel-sanche]

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

[gemini-code-assist]

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request executes a significant cleanup and update operation. It primarily updates the python-librarian-generator image to its latest version. Concurrently, it systematically removes the entire google-cloud-firestore client library, along with its associated administrative and bundling modules, from the codebase. This extensive removal also includes various project-level configuration and documentation files that were specific to the Firestore client, indicating a major restructuring or deprecation of this library within the project, following a reported generation failure.

Highlights

• Librarian Image Update: The python-librarian-generator Docker image has been updated to a new SHA256 hash: eec191fc4904c204cd717c79812cd66997b5559776483ee223f69c8f43e99224.
• Google Cloud Firestore Removal: All files and configurations related to the google-cloud-firestore client library, including its firestore_admin_v1 and firestore_bundle sub-components, have been entirely removed from the repository.
• Configuration File Cleanup: Several root-level configuration files (.pre-commit-config.yaml, .repo-metadata.json, .trampolinerc) and documentation files (README.rst, docs/README.rst, docs/summary_overview.md) specific to the removed Firestore library have been deleted.
• Coverage Configuration Adjustment: The .coveragerc file was updated to remove old copyright information, add a new source-of-truth comment, and adjust omit patterns to exclude the now-removed firestore_admin components from coverage checks.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, which appears to be an automated update of the generator image, has resulted in the deletion of a vast number of source and configuration files. The PR description itself notes that "Generation failed for - google-cloud-firestore". These deletions will break the library. Furthermore, several changes introduce significant regressions in project standards, such as removing the 100% test coverage requirement, pre-commit hooks, the README, and the security policy. This PR is in a broken state and should not be merged. The underlying generation failure needs to be investigated and fixed.

I am having trouble creating individual review comments. Click here to see my feedback.

README.rst (1-197)

The README.rst file has been removed. A project's README is essential for users and contributors to understand its purpose, how to install it, and how to get started. Its removal will make the project much harder to use and contribute to. This is likely an error from the generator and must be fixed.

SECURITY.md (1-7)

The SECURITY.md file, which contains the security policy for reporting vulnerabilities, has been removed. This is a critical file for any project, and its absence leaves users without a clear process for reporting security issues. This should be restored.

google/cloud/firestore_admin_v1/gapic_version.py (1-16)

A very large number of source files, including this one, have been deleted across the google/cloud/firestore_admin_v1, google/cloud/firestore_v1, and google/cloud/firestore_bundle packages. This appears to be a result of the generator failure mentioned in the PR description and will completely break the library. This PR should not be merged until the generation issue is resolved and the files are restored.

.coveragerc (25)

The removal of fail_under = 100 is a significant regression. It removes the enforcement of 100% test coverage, which can lead to a decrease in code quality and reliability. Was this intentional? If so, it should be discussed and documented. If not, it should be restored.

.pre-commit-config.yaml (1-31)

The removal of the .pre-commit-config.yaml file is concerning. This disables pre-commit hooks for linting and formatting (e.g., black, flake8), which are important for maintaining code quality and consistency. This seems to be an unintended side effect of the failed generation and should be rectified.