-
Notifications
You must be signed in to change notification settings - Fork 83
chore: update gapic generated code #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update from the librarian tool, which updates the generator image. This has resulted in widespread changes across the codebase. Notably, the execute_pipeline feature has been removed, which is a significant breaking change that should be communicated to users. Other changes include updates to import ordering, code style, removal of generator-specific comments, and the addition of version checks. My review identifies a couple of minor issues introduced during this automated process: a typo in a comment and a docstring formatting regression. Otherwise, the changes appear to be the intended result of the generator update.
| ``TargetChange.target_ids`` are undefined. Therefore, | ||
| clients should provide a target ID instead of relying on the | ||
| server to assign one. | ||
| ``TargetChage.target_ids`` are undefined. Therefore, clients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - For EUCLIDEAN, COSINE: WHERE distance <= | ||
| distance_threshold | ||
| - For DOT_PRODUCT: WHERE distance >= distance_threshold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of this docstring has been degraded, making it harder to read. The code examples have lost their backticks and are now split across lines. Please restore the previous formatting for better readability.
| - For EUCLIDEAN, COSINE: WHERE distance <= | |
| distance_threshold | |
| - For DOT_PRODUCT: WHERE distance >= distance_threshold | |
| - For EUCLIDEAN, COSINE: | |
| ``WHERE distance <= distance_threshold`` | |
| - For DOT_PRODUCT: ``WHERE distance >= distance_threshold`` |
chore: librarian update image pull request: 20251216T191850Z