fix: Add missing metadata field to InlinedResponse #1887
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The InlinedResponse class was missing the metadata field that is documented in the REST API and present in InlinedRequest. This prevented users from tracking custom identifiers through batch processing. Fixes googleapis#1886
imohitkr
force-pushed
the
fix/inlined-response-metadata
branch
from
7612278 to
20ad65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
metadatafield toInlinedResponseclass intypes.pymetadatafield toInlinedResponseDictTypedDict intypes.py_InlinedResponse_from_mldevinbatches.pyto copy the metadata field from the API responseProblem
InlinedResponsewas missing themetadatafield that is documented in the REST API and present inInlinedRequest. This prevented users from tracking custom identifiers through batch processing.Fixes #1886