Skip to content

Conversation

@PeterC89
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2259 🦕

This PR does a number of things:

  • Removes redundant request options
  • Removes old http-proxy-agent based proxying as this isn't supported by native node fetch
  • Adds undici's EnvHttpProxyAgent to support proxies using standard environment vars
  • Bumps minimum node version to 20 as 18 is EOL

@PeterC89 PeterC89 requested review from a team as code owners July 21, 2025 14:52
@google-cla
Copy link

google-cla bot commented Jul 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 21, 2025
@meiswjn
Copy link

meiswjn commented Aug 20, 2025

Nice PR!
@chingor13 any ETA on this already? Thanks!

@kauppfbi
Copy link

Hey @chingor13, is there any update on this PR? Any plans to introduce and release it soon, or do you plan a different implementation for #2259?

@schulmak
Copy link

Any updates on this PR? We would really appreciate a merge if nothing blocks it!

@hmrc87
Copy link

hmrc87 commented Dec 16, 2025

@chingor13 heavily needed here

@ferrarimarco
Copy link
Collaborator

Hi @PeterC89. Can you please rebase against the latest main, and elaborate on the changes you're proposing? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy fails when using HTTP CONNECT (E.G. HTTPS via a HTTP only proxy)

7 participants