Spelling #2609

jsoref · 2025-10-19T18:00:36Z

This PR corrects misspellings identified by the check-spelling action

The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/release-please/actions/runs/18634010857/attempts/1#summary-53122636858

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes Spelling errors identified by check-spelling #2608 🦕

generated-files-bot · 2025-10-19T18:00:42Z

Warning: This pull request is touching the following templated files:

.kokoro/trampoline.sh - .kokoro files are templated and should be updated in synthtool
.kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool

jsoref · 2025-10-19T18:02:18Z

__snapshots__/setup-cfg.js


 license = Apache 2.0
-platforms = Posix, MacOS X, Windows
+platforms = POSIX, MacOS X, Windows


This is the canonical and correct spelling: https://pypi.org/search/?c=Operating+System+%3A%3A+POSIX

Note that MacOS X is wrong, but it's messed up in PyPI, so I'm not proposing "fixing" it.

jsoref · 2025-10-19T18:03:26Z

src/updaters/release-please-config.ts

    'changelog-sections': config.changelogSections,
    'release-as': config.releaseAs,
-    'skip-github-release': config.skipGithubRelease,
+    'skip-github-release': config.skipGitHubRelease,


jsoref · 2025-10-19T18:04:10Z

src/factory.ts

  });
  const strategyOptions: BaseStrategyOptions = {
-    skipGitHubRelease: options.skipGithubRelease, // Note the case difference in GitHub
+    skipGitHubRelease: options.skipGitHubRelease, // Note the case difference in GitHub


I'm proposing to make this a breaking api change (along with a few others)

jsoref · 2025-10-19T18:04:38Z

src/github.ts

            // merges will be matched, but rebase merged PRs will only be matched
            // if they contain a single commit. This is so PRs that are rebased
-            // and merged will have ßSfiles backfilled from each commit instead of
+            // and merged will have files backfilled from each commit instead of


I looked at the history and this just feels like an error

jsoref · 2025-10-19T18:05:17Z

src/manifest.ts

  // Strategy options
  releaseAs?: string;
-  skipGithubRelease?: boolean; // Note this should be renamed to skipGitHubRelease in next major release\
+  skipGitHubRelease?: boolean;


It seems worth making a major release to fix this at some point, why not now? :)

jsoref · 2025-10-19T18:06:21Z

CHANGELOG.md

Some projects don't like changing changelogs. I'm happy to drop if that's desired.

jsoref · 2025-10-19T18:17:48Z

I understand that the commits don't follow conventional commits. I'll drop/rearrange commits as directed and then make them fit conventional commits style.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2025-10-21T00:58:14Z

I sent Spelling synthtool#2134

jsoref requested review from a team as code owners October 19, 2025 18:00

product-auto-label bot added the size: m Pull request size is medium. label Oct 19, 2025

blunderbuss-gcf bot assigned chingor13 Oct 19, 2025

jsoref commented Oct 19, 2025

View reviewed changes

jsoref force-pushed the spelling branch from 278291d to 23cd4c7 Compare October 19, 2025 18:07

jsoref added 22 commits October 19, 2025 14:19

spelling: ; otherwise,

c8a00ec

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: a

e203b4c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: above

a0c3f82

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: across

48f55d6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: add

1e144ea

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: an

f4be7f0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anymore

63ea740

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: apis

557f9c3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bootstrapper

eefa23b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: candidate

c4cd4b2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: case-insensitive

ad13552

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: changelog

bf4d2b6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: command:

1d1ac9e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: conventional

a116429

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: decided

4ea90fe

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exception:

49989ab

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: fall back

880fb5d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: files

f6e0d70

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: five

6ebc5f1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: github

0197e81

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: google

6b1b467

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: if

a90e144

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 28 commits October 19, 2025 14:19

spelling: match

d53d55c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: native

b48e034

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: nonexistent

4c5713e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: occurred

07ed86f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: one

afe653f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: otherwise,

edd455c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: parentheses

2997279

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: please

bd6e44c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: posix

05ac026

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: privileged

708f1bf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: referencing

6db3b4d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: request

624e558

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: resolve

10ab99f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: satisfied

fbaaee4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: sections

667c5e0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: separator

5d26e33

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: strategy

61cfdc3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: supports

44ee2d9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: tf and

2119d90

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: than

26884aa

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

f06073e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: triggered

96e9eae

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: two

c29af55

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: typescript

0b270ce

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: when

9b5a547

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whether or not

4cf2df5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with a leading space

e3063f7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: without

5536451

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 23cd4c7 to 5536451 Compare October 19, 2025 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Spelling #2609

Spelling #2609

Uh oh!

jsoref commented Oct 19, 2025

Uh oh!

generated-files-bot bot commented Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Uh oh!

jsoref commented Oct 19, 2025

Uh oh!

jsoref commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Spelling #2609

Are you sure you want to change the base?

Spelling #2609

Uh oh!

Conversation

jsoref commented Oct 19, 2025

Uh oh!

generated-files-bot bot commented Oct 19, 2025

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

jsoref commented Oct 19, 2025

Uh oh!

jsoref commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants