This repository was archived by the owner on Mar 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
First merge #2
Open
sachinhosmani
wants to merge
116
commits into
reviewed
Choose a base branch
from
master
base: reviewed
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
First merge #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ree when page is refreshed.
…elections in element tree. Properties need better selection.
… the object inspector
… change in progress.
…): no source build at home
…ems with unwanted properties being added in response to using setters.
…ighlighted to show the model behind it (WIP). Breakpoints support added, but buggy because of core-selector
… other bugs. Fixed switching between selected elements.
…n DOM mutation observer.
….js. Removed repetitive parts of 'init', moved it to 'createPageView' in panel-orig.js
…bs for parent elements in local DOM view.
…n happens and local DOM root is affected. Some concurrency updates with dom-mutation and page refresh.
add vulcanize to install directions.
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
I signed the CLA. |
Thanks for signing the CLA! |
Closes #32 The extension fails to install in Chrome without perfContentScript.js in the build folder.
Copy perfContentScript.js to build folder
Tinted overlay instead of an outline for highlighted elements
Warn about unregistered custom elements
Closure Compiler download link was ~3 years out of date.
Fixed Closure Compiler download link.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method-list
(for adding breakpoints) isn't ready yet becausecore-selector
is buggy.The plan is to put
method-list
andobject-tree
on the right side in separate tabs. Butpaper-tabs
was not being compliant withvulanize
, so that's not done yet.Requires
O.o()
to work.Thank you
Update for #2:
core-selector
still needs to be rewritten and somethod-list
(for breakpoints) is kind of buggy.Issue with
paper-tabs
got sorted out, so there are tabs on the right now.